Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update Request]: rename dbeaver.dbeaver to DBeaverCorp.DBeaverCommunityEdition #205598

Open
rovabunw opened this issue Jan 3, 2025 · 2 comments
Open

[Update Request]: rename dbeaver.dbeaver to DBeaverCorp.DBeaverCommunityEdition #205598

rovabunw opened this issue Jan 3, 2025 · 2 comments
Labels
Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated

Comments

@rovabunw
Copy link
Contributor

rovabunw commented Jan 3, 2025 •
edited
Loading

What type of update are you requesting?

A new version of an existing package

Current Package Identifier

dbeaver.dbeaver

Package Version

24.3.1

Please describe the changes you would like to see

DBeaverCorp.DBeaverEnterpriseEdition is now available too. I suggest to rename this package:

DBeaver Community Edition dbeaver.dbeaver
DBeaver Enterprise Edition DBeaverCorp.DBeaverEnterpriseEdition

to

DBeaver Community Edition DBeaverCorp.DBeaverCommunityEdition
DBeaver Enterprise Edition DBeaverCorp.DBeaverEnterpriseEdition
@rovabunw rovabunw added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Jan 3, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 3, 2025
@rovabunw rovabunw changed the title [Update Request]: [Update Request]: rename dbeaver.dbeaver to DBeaverCorp.DBeaverCommunityEdition Jan 3, 2025
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 3, 2025
@Dragon1573
Copy link
Contributor 

00:07:14 D:\...\winget-pkgs  [master ≡] 1ms pwsh$ winget search -s winget DBeaver
名称                       ID                                   版本
----------------------------------------------------------------------
DBeaver Community Edition  dbeaver.dbeaver                      24.3.1
DBeaver Enterprise Edition DBeaverCorp.DBeaverEnterpriseEdition 24.3.0

Is it better naming DBeaver.DBeaver.Community and DBeaver.DBeaver.Enterprise?

@Trenly
Copy link
Contributor

Trenly commented Jan 3, 2025 

00:07:14 D:\...\winget-pkgs  [master ≡] 1ms pwsh$ winget search -s winget DBeaver
名称                       ID                                   版本
----------------------------------------------------------------------
DBeaver Community Edition  dbeaver.dbeaver                      24.3.1
DBeaver Enterprise Edition DBeaverCorp.DBeaverEnterpriseEdition 24.3.0

Is it better naming DBeaver.DBeaver.Community and DBeaver.DBeaver.Enterprise?

If you do that, you have to fully remove dbeaver.dbeaver first as having the mixed casing would cause issues with Git on Windows. I think in this case, DBeaverCorp.DBeaver.Community and DBeaverCorp.DBeaver.Enterprise would be cleanest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Trenly @rovabunw @Dragon1573 @stephengillie