chore: add "Thanks" section to release-please configuration #5276
Conversation
|
Can you give some reference to how this works? I wasn't aware that release-please could do this, so would love to know where I missed it |
|
Oh hey Sir, unfortunately this doesn't work as expected, however, I'm trying out other methods like writing a script or creating a custom plugin for it. |
- Fetches contributor details for merged PRs using GitHub's API. - Enhances auto-generated release notes by tagging contributors. - Prepares for integration into the release workflow. A special holiday update to spread cheer and gratitude this Christmas season! 🎅🎁 Resolves mochajs#5272 (ho ho ho)
| @@ -102,7 +102,7 @@ describe('ParallelBuffered', function () { | |||
| describe('on EVENT_RUN_END', function () { | |||
| it('should remove all listeners', function () { | |||
| runner.emit(EVENT_RUN_END); | |||
| expect(runner.listeners(), 'to be empty'); | |||
| expect(runner.listenerCount(EVENT_RUN_END), 'to equal', 0); | |||
There was a problem hiding this comment.
🤔 if there's something wrong with this test, it should be fixed in its own issue -> PR. Any CI failures also happening on main don't need to block or be fixed by this PR.
There was a problem hiding this comment.
[Change request] As a design point, I don't think taking on the burden of a full script is ideal. Assuming release-please doesn't have contribution thanks as a core feature, I think the next best thing would be a plugin. Which is a thing that can be made: https://github.com/googleapis/release-please/blob/3bae6137f939a4db2df1d32436453d1ac2a41e9f/docs/manifest-releaser.md#plugin-usage
googleapis/release-please#2221 tracks them adding more docs and also links to some information + existing plugins.
Is that an approach you think could work?
JoshuaKGoldberg
added
the
status: waiting for author
PR Checklist
status: accepting prsOverview
This PR modifies the release-please configuration to include contributor acknowledgments in our release notes, similar to typescript-eslint's format. This change will: