Tel input type not taken into account in twig

[damiensan]

Hello,

I don't know if this issue relates to Symfony or to the bundle.

When I use

$builder->add('mobile', PhoneNumberType::class, [
    'widget' => PhoneNumberType::WIDGET_COUNTRY_CHOICE,

the input rendered by twig is an input type="text" instead of input type="tel"

Do you know how to fix this, did I miss something ?

Thank you

[maxhelias]

Can you publish a reproduce pls ? That way it will be quicker for me to see what's wrong.

[damiensan]

Hello, here it is

Expected Behavior

When I use the PhoneNumberType I want to have a input type="tel" rendered in html not a input type="text"

Current Behavior

The input rendered is a text one.

Steps to Reproduce

1. Create a Symfony Type

class AddressType extends AbstractType
{
public function buildForm(FormBuilderInterface $builder, array $options): void
    { 
    $builder->add('phone', PhoneNumberType::class, [
            'widget'                    => PhoneNumberType::WIDGET_COUNTRY_CHOICE
        ]);
    }
}

Render it in Twig

When I look at the PhoneNumberType, I see

 public function buildView(FormView $view, FormInterface $form, array $options): void
    {
        $view->vars['type'] = 'tel';
        $view->vars['widget'] = $options['widget'];
    }

which seems fine to me.

It seems that the form_layout.div.html.twig does not take this option into account.

Thank you.

[damiensan]

Hello, any news on this ?
Regards

[Nek-]

Thank you very much for your issue.

And you're right! It could be better. Not that easy though.

We need to:

1. Bring the ability to use the tel type with an option.
2. Trigger a deprecation when the option is not specified.
3. Plan a change in the next major version on this specific field because it should be the default!

You can make a PR for this change if you want.

[abdellahrk]

Can you throw more light on these following points? I just sent a PR maybe I can update it.

We need to:

1. Bring the ability to use the tel type with an option.
2. Trigger a deprecation when the option is not specified.
3. Plan a change in the next major version on this specific field because it should be the default!

[odolbeau]

According to the latest available form_div_layout.html.twig, this option looks correctly handled by symfony.

Could you provide more details regarding versions you're using? Maybe a reproducer project with minimal dependencies?

[mrcmorales]

hi @odolbeau

May be the problem is that the form type is TextType and not TelType ?

@see https://github.com/odolbeau/phone-number-bundle/blob/master/src/Form/Type/PhoneNumberType.php#L111

[odolbeau]

@mrcmorales You're right, I was looking for the single_text widget! 👍
@abdellahrk provided PR #182 to fix this issue but when need to correctly handle the "kind of" BC Break it could introduce (see PR).