Compute the osm places shape #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but still lots of todos 😉
amatissart
reviewed
Oct 31, 2018
| for (idx, voronoi) in voronois.into_iter().enumerate() { | ||
| let place: &mut Zone = &mut places[idx]; | ||
|
|
||
| place.boundary = make_boundary(voronoi, &calc_geom); |
There was a problem hiding this comment.
TODO: result = (voronoi - calc_geom) ∩ parent_geom
amatissart
reviewed
Oct 31, 2018
|
|
||
| let calc_geom = create_forbidden_geom(&zones[parent.index]); | ||
| for (idx, voronoi) in voronois.into_iter().enumerate() { | ||
| let place: &mut Zone = &mut places[idx]; |
There was a problem hiding this comment.
TODO: places and points use same indices, but that's not obvious
|
Replaced with #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmogony.world still has a lot of missing cities. This is mainly due to the cities shape not being in osm.
But in osm, when cities are missing, there are often nodes with
type=cityortype=town.In this PR we try to compute rough shape for those nodes.
In order to do this, we compute a voronoi diagrams for each "parent" zone.
the algorithm is roughly:
for each parent:
type=cityortype=town] in it and compute a voronoi from itThis PR is a work in progress. There are still lots a TODOs and it depends on:
This should fix #19