Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it harder to forget to submit targets/filters subform #2627

Open
david-crespo opened this issue Dec 17, 2024 · 2 comments · May be fixed by #2634
Open

Make it harder to forget to submit targets/filters subform #2627

david-crespo opened this issue Dec 17, 2024 · 2 comments · May be fixed by #2634
Assignees
Milestone

Comments

@david-crespo
Copy link
Collaborator

david-crespo commented Dec 17, 2024

@iliana reports (and I think @charliepark have discussed this before) that it feels like the firewall rules form is just ignoring your target because you typed it in but forgot to click Add Target. There is probably something we can do about this. It's probably too much to refuse to submit the overall form if there's unsubmitted stuff in the target or filter field, but we can probably warn the user somehow.

Image
@charliepark
Copy link
Contributor

I'm not totally against disabling the form if there's stray data. "You have an unsaved {target|host} filter; save or clear it to create this firewall rule."

@david-crespo
Copy link
Collaborator Author

Yeah, on second thought it’s rare enough that it doesn’t feel like too much friction.

@charliepark charliepark added this to the 13 milestone Jan 6, 2025
@charliepark charliepark self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants