You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Slog itself recommends using tracing, so let's use tracing.
Also: slog env_looger is a bit derpy to set up with defaults that provide useful logging information for falcon CLI applications. In particular, the need to set the environment variable RUST_LOG with std::env::set_var is unsafe from multi-threaded code.
I don't think this by itself is a reason to switch? Programs construct the slog loggers and can specify whatever logger they want, and they can honor whatever environment variables they want in determining that, can't they?
Slog itself recommends using tracing, so let's use tracing.
Also: slog env_looger is a bit derpy to set up with defaults that provide useful logging information for falcon CLI applications. In particular, the need to set the environment variable
RUST_LOG
withstd::env::set_var
is unsafe from multi-threaded code.falcon/lib/src/lib.rs
Lines 252 to 261 in 979dc84
Hopefully, we can find a better path forward with tracing for user-configurable log levels with a useful default.
The text was updated successfully, but these errors were encountered: