Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APCB configuration should not include BMC early link training #64

Open
wesolows opened this issue Mar 10, 2023 · 1 comment
Open

APCB configuration should not include BMC early link training #64

wesolows opened this issue Mar 10, 2023 · 1 comment
Assignees
Milestone

Comments

@wesolows
Copy link
Contributor

The current example blob configuration for Gimlet in amd-host-image-builder leaves intact the Ethanol-X early PCIe link training configuration used to connect with the BMC. This doesn't exist at all on Gimlet and the feature should be disabled in our Gimlet configuration.

@wesolows wesolows added this to the MVP milestone Mar 10, 2023
@dancrossnyc dancrossnyc assigned dancrossnyc and daym and unassigned dancrossnyc May 1, 2023
daym pushed a commit that referenced this issue May 5, 2023
#64 APCB configuration should not include BMC early link training
@wesolows
Copy link
Contributor Author

Somehow this was moved to the Done state in the external milestone tracker (which I do not believe should ever be done except by the bot) but is still open here. It looks like there was an attempt to address this via 71bcc95; should this bug be closed? The commit message referenced #76, not this bug, so I can't tell what was intended. All commit messages should include a single line identifying each bug or RFE that it addresses, in the form

repo#bugno verbatim synopsis of the bug from the ticketing system

If the repository is illumos-gate master, the repo# portion should be omitted and a list of reviewers included after the list of tickets; see documentation at illumos.org.

That makes it easy to determine whether a ticket has inadvertently been left open. Has this one, or is there still work to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants