reconfigurator does not try to remove expunged datasets #7304
Assignees
Comments
This was referenced Jan 3, 2025
|
Datasets ledger (sled g0, generation 3): a4x2datasets-g3.txt |
|
To summarize:
To confirm, the dataset is currently being marked "expunged" in the blueprint - as far as blueprint data goes, this is currently correct, right? (I'm trying to make sure I grok where we're saying things need to be fixed) Or is this more about the process of transitioning an "expunged dataset in the blueprint" to "fully removing the dataset that has already been marked expunged" from the blueprint? |
|
Yes, I believe the dataset is being marked expunged in the blueprint and that is correct. What I was trying to cover with this issue is having Reconfigurator stop including these expunged datasets in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I expunged an external-dns zone from a freshly-deployed a4x2 system. Things seemed to work, but executing the blueprint that expunged the zone did not change the configured datasets at all (i.e., reconfigurator didn't even try to remove the dataset that was expunged).
This is closely related to #6177 but that ticket covers the sled-agent side, whereas this covers the client (reconfigurator) side. We need to be careful about the order in which we fix this issue, #6177, and #6999 for the reason mentioned here.
Concretely, I started from what's described in #7299, which is basically a freshly deployed system with a few extra blueprints (with no meaningful changes). Then I used reconfigurator-cli to create a new blueprint that expunged the external-dns zone:
The diff looks right:
Ran into #7302 again -- those datasets that changed, they changed only in disposition from "in-service" to "expunged". I imported the blueprint:
then we can see in the database that that's the only column that changed:
I confirmed that they appear expunged in the blueprint JSON file that was saved above:
Then I executed it:
So that worked. The ledger on the affected sled was updated:
But the only change is that it went from generation 2 to 3 (as the diff output said it would):
and the expunged datasets are still there:
The text was updated successfully, but these errors were encountered: