turn on "require PRS up to date" branch control

[sneakers-the-rat]

What do ppl think about adding the "require branches be up to date before merging" branch protection rule to main? I think it helps avoid problems when there are lots of overlapping changes happening, that e.g. a merge that passed tests on its last commit could still break things if the base has changed since then?

[blink1073]

Looks like we have quorum, I've added the rule.

[sneakers-the-rat]

I don't mean to be annoying but it looks like that's a different rule? this was the one i was thinking of:

I am also fine with requiring pull request before merging, and have found 'dismiss stale approvals' to be slightly annoying in combination with 'require branches be up to date' because it was pretty common with us to review something, approve it, then before merging do a final rebase and that triggers the need for a new review. maybe since this isn't a "security-conscious" package and we're not anticipating people trying to sneak through changes we disable that? but also no strong preference

[Midnighter]

I agree, especially with a globally distributed group of volunteers, let's not be too strict.

[blink1073]

Updated!

[blink1073]

I chose a subset for the required checks:

[lwasser]

hi!! I'm late to the convo here, but I totally trust all the decisions that you all make on this. so we could potentially close this issue or keep it opened as you all see fit!! i don't want to slow progress down!