You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Parentheses should be added around the 2nd argument to assertAlmostEqual (or the - 1 changed to + 1).
assertAlmostEqual doesn't error if the difference between the first two arguments equals the delta argument.
(With that said, I just ran unittest2pytest on 28k lines of real test code and this was the only problem I encountered other than the pytest.raises limitation described at the bottom of your README. Nice work!)
The text was updated successfully, but these errors were encountered:
bmw
changed the title
Missing necessary parentheses
Missing necessary parentheses and not allowing equality
Feb 15, 2023
In my work on certbot/certbot#9585,
unittest2pytest
rewrote these lines:as
This is incorrect for two reasons:
assertAlmostEqual
(or the- 1
changed to+ 1
).(With that said, I just ran unittest2pytest on 28k lines of real test code and this was the only problem I encountered other than the
pytest.raises
limitation described at the bottom of your README. Nice work!)The text was updated successfully, but these errors were encountered: