Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set time range on individual entities via blueprint api #8557

Open
Wumpf opened this issue Dec 20, 2024 · 0 comments
Open

Can't set time range on individual entities via blueprint api #8557

Wumpf opened this issue Dec 20, 2024 · 0 comments
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 🐍 Python API Python logging API 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@Wumpf
Copy link
Member

Wumpf commented Dec 20, 2024

Adding this to the helix demo doesn't have any effect right now:

    blueprint = rrb.Blueprint(
        rrb.Spatial3DView(
            origin="/",
            overrides={
                "helix/structure/scaffolding/beads": [
                    rrb.VisibleTimeRange(
                        "stable_time",
                        start=rrb.TimeRangeBoundary.cursor_relative(seconds=-0.3),
                        end=rrb.TimeRangeBoundary.cursor_relative(seconds=0.3),
                    ),
                ]
            },
        ),
    )
    rr.send_blueprint(blueprint)

We store it already in the blueprint but it's stored on "recursive override path" which is a vestigue from back when we tried a model of "indidual & recursive" overrides. We dumped that idea and instead want to make overrides be path-expression enabled in the future. Individua/recursive is really only used for recursive visibility & interactivity today and we should clean up everything else. See:

Python blueprint api overrides use only the "individual" override path.

-> The fix MIGHT be as easy to change these two code paths to use "individual" instead. But a bit more looking into is needed

We also should really add a test for this - at least a release_checklist one

@Wumpf Wumpf added 🐍 Python API Python logging API 🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 🐍 Python API Python logging API 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Development

No branches or pull requests

1 participant