Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC: Simplify codec and provide encoding/decoding for DataframePart directly #8356

Closed
zehiko opened this issue Dec 9, 2024 · 0 comments · Fixed by #8614
Closed

gRPC: Simplify codec and provide encoding/decoding for DataframePart directly #8356

zehiko opened this issue Dec 9, 2024 · 0 comments · Fixed by #8614
Assignees
@zehiko
Labels
remote-store remote store gRPC API

Comments

@zehiko
Copy link
Contributor

zehiko commented Dec 9, 2024

What

  • we need to simply get rid of NoData message and the whole header shenanigans that we have right now
  • add encode and decode to DataframePart to avoid the need to explicitly define codec version, but instead "hide" it beneath those helper methods

Related PR: #8328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zehiko zehiko

Labels
remote-store remote store gRPC API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve ergonomics of encoding and decoding data (using arrow IPC) rerun-io/rerun
1 participant
@zehiko