Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmsign uses a predictable filename for temporary file(s), can leave them behind #3486

Open
pmatilai opened this issue Dec 11, 2024 · 0 comments
Labels

Comments

@pmatilai
Copy link
Member

Ran into this related to #3469: there appears to be a some path where --addsign/--resign leaves the temporary .sig file behind on failure. And because the name of the .sig file is formed from the package name by just appending .sig, any attempts to sign the same package again in the same location will fail because of that.

We shouldn't leave temporary files behind, period. And, we should use a non-predicatable name for it anyhow. The current method places the .sig file in the same directory as the package is in, so non-safe for world-writable directories in particular. /tmp is maybe not the place to sign your packages, but we could handle this better...

@pmatilai pmatilai added the bug label Dec 11, 2024
@pmatilai pmatilai added this to RPM Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in RPM Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant