Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score deviates from upstream #15

Open
ghtm2 opened this issue Dec 28, 2022 · 1 comment
Open

Score deviates from upstream #15

ghtm2 opened this issue Dec 28, 2022 · 1 comment

Comments

@ghtm2
Copy link

ghtm2 commented Dec 28, 2022

Hi.

I've just compiled both upstream and this and was a bit surprised to find quite a bit of deviation in the score on the same set of images.

Here is a sample.

With upstream ssimulacra2 I get a score of 77.94549165, with ssimulacra2_bin one of 78.74256984.

Is this known/expected?

@FreezyLemon
Copy link
Contributor

FreezyLemon commented Feb 24, 2023

This is known and pretty much unavoidable. Both the C++ and the Rust versions have some optimizations in (maybe different) places to increase speed in certain places, and unless there is extra effort invested into matching these optimized functions 1:1, there will always be a difference.

That said, if the deviation is too large it is actually a problem, so it might be worth investigating this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants