Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check soundness of static ref inside SystemTable #685

Closed
nicholasbishop opened this issue Mar 9, 2023 · 2 comments
Closed

Check soundness of static ref inside SystemTable #685

nicholasbishop opened this issue Mar 9, 2023 · 2 comments

Comments

@nicholasbishop
Copy link
Member

It was pointed out in a reddit thread that this might not be sound when exiting boot services: https://www.reddit.com/r/rust/comments/11m3bq8/comment/jbid9sd/?utm_source=reddit&utm_medium=web2x&context=3 Thanks @DianaNites!

I haven't taken a proper look at it yet, but filing an issue as a reminder.
@phil-opp
Copy link
Member

Now that #710 is merged, can this be closed?

@nicholasbishop nicholasbishop mentioned this issue Mar 26, 2023
Open
@nicholasbishop
Copy link
Member Author

Yep this is done. I have some more investigation I want to do regarding potential UB, tracked in #715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicholasbishop @phil-opp