Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Reactification #126

Open
9 of 23 tasks
ltegman opened this issue Apr 15, 2016 · 11 comments
Open
9 of 23 tasks

Tracking Reactification #126

ltegman opened this issue Apr 15, 2016 · 11 comments
Assignees
Milestone

Comments

@ltegman
Copy link
Member

ltegman commented Apr 15, 2016

Primary motivation for switching this to React is that turning the client-side into a SPA is an easy way to stop us from spamming sockets and event listeners on our server-side, which we currently do every time someone navigates to a new page. It will also allow us to keep accelerometer history when the user navigates away from that page.

Here I'm tracking work that needs to be done for this milestone:

Components

  • Nav
  • Connect
    • Basic Skeleton
    • Wire up connection logic
  • Move
    • Basic Skeleton
    • Get graphs working in react
    • Wire up socket events
  • Color
    • Basic Skeleton
    • Get color picker working in react
    • Wire up socket events
  • Presets
    • Basic Skeleton
    • Wire up socket events
  • About

Misc

  • Install deps and add build process to gulp
  • Serve new build files instead of jade templates
  • Fix broken gulp watch task
  • Consolidate statically served files into one place?
  • Fix tests

Stretch

  • Add React testing
  • Add server side React rendering
@ltegman ltegman self-assigned this Apr 15, 2016
@ltegman ltegman added this to the Reactify milestone Apr 15, 2016
@ghost
Copy link

ghost commented Apr 15, 2016

I like it! I'm going to be looking through the React courses @jessethach sent me, so this would be a fun thing to tackle after the hackathon.

Were you wanting to make this a solo venture or looking for help on tasks?

@ltegman
Copy link
Member Author

ltegman commented Apr 15, 2016

I'm game for any help people want to lend! I'm doing it in a reactify branch on the main repo so that anyone on the team can take a look or contribute 😄

@xxnatc
Copy link
Member

xxnatc commented Apr 15, 2016

I'm in! But I do need some time to catch up on the react magic after the hackathon.

@sabbyt
Copy link
Contributor

sabbyt commented Apr 15, 2016

Me too! I've been meaning to add a games section too! 😃
Sent from my iPhone

On Apr 14, 2016, at 21:52, Natalie Chow [email protected] wrote:

I'm in! But I do need some time to catch up on the react magic after the hackathon.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@jessethach
Copy link
Member

I have some ideas. I can send some PRs for review soon.

@jessethach
Copy link
Member

@ltegman we can probably turn the switch statement from the gamepad.js file into action types in Redux.

@ltegman
Copy link
Member Author

ltegman commented Apr 15, 2016

@jessethach Would that be so we could store the button state in redux and use that to highlight the currently pressed button?

@jessethach
Copy link
Member

@ltegman Definitely – same could be done with the motion-socket file.

@ltegman
Copy link
Member Author

ltegman commented Apr 16, 2016

I've fixed the tests by removing the no longer used (and therefore broken) router tests. Some tests fail when run in gulp because it runs so much slower, so that may be something to look into, but it's not high on my priority list.

@xxnatc
Copy link
Member

xxnatc commented Apr 18, 2016

Did someone say React?

@ltegman
Copy link
Member Author

ltegman commented Apr 27, 2016

I'm most of the way done with porting the basic skeletons of the pages. Still will need to wire up the actions and handle stuff like graphs and the color picker in react

Thinking about switching to this for color picking: http://casesandberg.github.io/react-color/

Thinking about using this for wiring up all our UI actions that use sockets: https://www.npmjs.com/package/redux-socket.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants