Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying bitflags #89

Open
SonnyX opened this issue Dec 24, 2020 · 3 comments
Open

Simplifying bitflags #89

SonnyX opened this issue Dec 24, 2020 · 3 comments
Labels
enhancement help wanted

Comments

@SonnyX
Copy link
Contributor

SonnyX commented Dec 24, 2020

Another potential way to improve code, albeit at the expense of adding another dependency
master...Alovchin91:feature/bitflags
@pravic
Copy link
Member

pravic commented Dec 24, 2020

But it's safer. I have to do this eventually.

@pravic pravic changed the title SImplifying bitflags Simplifying bitflags Jan 10, 2021
@SonnyX
Copy link
Contributor Author

SonnyX commented Apr 13, 2021

Here is another repo implementing some more bitflags, along with mutability changes and other improvements:
master...kwdkk:master

@pravic
Copy link
Member

pravic commented Apr 13, 2021

Yeah. The bitflags is a total win but other changes seem controversial and arguable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pravic @SonnyX