Inject methods with mocked dependencies

[5outh]

As of Laravel 5, Controller methods can utilize dependency injection. We should be able to deal with this by proxying the call to each method with a wrapper function call in InjectedTrait.

i.e.

class SomeController
{
    public function someMethod(SomeDependency $dependency)
    {
        // Do stuff...
    }
}

In our tests, I'd like to be able to do:

$controller = $this->make();

$args = $controller->call('someMethod');

$args->dependency->shouldReceive(/*...*/);

The exact way this works is up for debate, but args should not be added directly to the test case, since the names of the dependencies may clash with class dependencies.

[etcinit]

I've had a task open on this for Impersonator for a while. I think the hardest part is figuring out what is a dependency and what is not.

Here's how I was planning to implementing it:

// string -> string -> Map<string, mixed> -> mixed
$impersonator->call(SomeClass::class, 'someMethod', ['userId' => 456]);

Everything that is not provided in the arguments array is considered a dependency. The developer is expected to fill out every argument without type hints. Everything else should be a mock previously provided by the developer or automatically mocked.

https://phabricator.chromabits.com/T14

[5outh]

Good idea 👍

The nice thing about InjectedTrait is that we'll already have the class name. The other nice thing is that the arguments can default to []! So here I think we can get away minimally with the syntax I mentioned above; I hadn't considered non-injected arguments though!

[etcinit]

For reference, here's my implementation: https://phabricator.chromabits.com/diffusion/NC/browse/master/src/Chromabits/Nucleus/Testing/Impersonator.php;37e11b98d0b851f4c01578ce73eef6b5d2342fe5$363

[etcinit]

Another thing to consider is default values. I need to add that. Essentially, if an argument is not provided, we should try to find a default value first before failing.