Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom attribute support #586

Closed
echlebek opened this issue Nov 21, 2017 · 1 comment
Closed

Custom attribute support #586

echlebek opened this issue Nov 21, 2017 · 1 comment
Assignees
@echlebek
Labels
1.x parity feature

Comments

@echlebek
Copy link
Contributor

In #458, the need for setting custom attributes in the CLI is identified. In this issue, I'll lay out a proposal for dynamic behaviour based on dynamic attributes in Sensu entities.
@echlebek echlebek changed the title Add custom attribute support Custom attribute support Nov 21, 2017
@echlebek echlebek self-assigned this Nov 21, 2017
@echlebek echlebek mentioned this issue Nov 22, 2017
Merged
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Vendor github.com/json-iterator/go to vendor.
13695b5 
Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Sort serialized custom attributes by field name.
a6c0d22 
Add tests for json Marshal/Unmarshal.

Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Rename 'custom' as 'extended'.
5640e85 
Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Simplify logic.
d42b845 
Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Add benchmarks.
6dab898 
Refs #586

goos: linux
goarch: amd64
pkg: github.com/sensu/sensu-go/types/dynamic
BenchmarkQueryGovaluateSimple-4    	  500000	      2069 ns/op	     992 B/op	      25 allocs/op
BenchmarkQueryGovaluateComplex-4   	  200000	      6212 ns/op	    2544 B/op	      75 allocs/op
BenchmarkUnmarshal-4               	  200000	      6492 ns/op	    6568 B/op	      57 allocs/op
BenchmarkMarshal-4                 	  300000	      4556 ns/op	    6512 B/op	      40 allocs/op
PASS
ok  	github.com/sensu/sensu-go/types/dynamic	6.172s
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Add Unmarshal function. Unexport GetExtendedAttributes.
8a23f5b 
This change makes the package significantly easier to use, and also
presents a greater symmetry between its types and functions.

This comes at a cost of additional reflection, which can be seen
in the benchmark for Unmarshal.

Old:
BenchmarkUnmarshal-4    6492 ns/op    6568 B/op      57 allocs/op

New:
BenchmarkUnmarshal-4    9244 ns/op    7592 B/op      77 allocs/op

Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Vendor github.com/json-iterator/go to vendor.
298d0f7 
Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Sort serialized custom attributes by field name.
7c64fea 
Add tests for json Marshal/Unmarshal.

Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Rename 'custom' as 'extended'.
9b0f914 
Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Simplify logic.
9bf89a8 
Refs #586
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Add benchmarks.
d0e00d2 
Refs #586

goos: linux
goarch: amd64
pkg: github.com/sensu/sensu-go/types/dynamic
BenchmarkQueryGovaluateSimple-4    	  500000	      2069 ns/op	     992 B/op	      25 allocs/op
BenchmarkQueryGovaluateComplex-4   	  200000	      6212 ns/op	    2544 B/op	      75 allocs/op
BenchmarkUnmarshal-4               	  200000	      6492 ns/op	    6568 B/op	      57 allocs/op
BenchmarkMarshal-4                 	  300000	      4556 ns/op	    6512 B/op	      40 allocs/op
PASS
ok  	github.com/sensu/sensu-go/types/dynamic	6.172s
echlebek added a commit that referenced this issue Nov 22, 2017
@echlebek
Add Unmarshal function. Unexport GetExtendedAttributes.
b808c8b 
This change makes the package significantly easier to use, and also
presents a greater symmetry between its types and functions.

This comes at a cost of additional reflection, which can be seen
in the benchmark for Unmarshal.

Old:
BenchmarkUnmarshal-4    6492 ns/op    6568 B/op      57 allocs/op

New:
BenchmarkUnmarshal-4    9244 ns/op    7592 B/op      77 allocs/op

Refs #586
@echlebek
Copy link
Contributor Author

I've opened Knetic/govaluate#84 in support of this work.

echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Upgrade govaluate, avoid generating structs.
32bf318 
Now that govaluate has been modified to recursively query
Parameters, we can return a lazy tree of AnyParameters instead of
dynamically generating structs. This saves quite a bit of code,
CPU time, and memory allocations.

Old struct generation
    BenchmarkQueryGovaluateSimple-4    2069 ns/op    992 B/op   25 allocs/op
    BenchmarkQueryGovaluateComplex-4   6212 ns/op   2544 B/op   75 allocs/op

New lazy json parsing
    BenchmarkQueryGovaluateSimple-4    1404 ns/op    320 B/op   18 allocs/op
    BenchmarkQueryGovaluateComplex-4   2617 ns/op    512 B/op   30 allocs/op

Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Simplify Get method.
5662f43 
Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Fix complex query benchmark.
e8bed18 
Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Look up struct fields by name.
8cc3f24 
Reduces cost of querying in the most common case.

Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Improve package ergonomics and fix a bug.
2845cdf 
* Break up Attributer interface into AttrGetter and AttrSetter.
* Get rid of the Attributes type in favour of simple []byte.
* Make AttrGetter method set match what protobuf might generate.
* When returning struct fields from GetField, use reflect.Indirect
  so that pointers are never returned.
* Make sure that extended attributes are never returned by GetField
  and never marshaled by Marshal.

Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Vendor github.com/json-iterator/go to vendor.
81f8ad3 
Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Sort serialized custom attributes by field name.
5872eeb 
Add tests for json Marshal/Unmarshal.

Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Rename 'custom' as 'extended'.
fb57fcc 
Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Simplify logic.
49f3182 
Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Add benchmarks.
0f062ba 
Refs #586

goos: linux
goarch: amd64
pkg: github.com/sensu/sensu-go/types/dynamic
BenchmarkQueryGovaluateSimple-4    	  500000	      2069 ns/op	     992 B/op	      25 allocs/op
BenchmarkQueryGovaluateComplex-4   	  200000	      6212 ns/op	    2544 B/op	      75 allocs/op
BenchmarkUnmarshal-4               	  200000	      6492 ns/op	    6568 B/op	      57 allocs/op
BenchmarkMarshal-4                 	  300000	      4556 ns/op	    6512 B/op	      40 allocs/op
PASS
ok  	github.com/sensu/sensu-go/types/dynamic	6.172s
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Add Unmarshal function. Unexport GetExtendedAttributes.
ae9b6c4 
This change makes the package significantly easier to use, and also
presents a greater symmetry between its types and functions.

This comes at a cost of additional reflection, which can be seen
in the benchmark for Unmarshal.

Old:
BenchmarkUnmarshal-4    6492 ns/op    6568 B/op      57 allocs/op

New:
BenchmarkUnmarshal-4    9244 ns/op    7592 B/op      77 allocs/op

Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Upgrade govaluate, avoid generating structs.
5739860 
Now that govaluate has been modified to recursively query
Parameters, we can return a lazy tree of AnyParameters instead of
dynamically generating structs. This saves quite a bit of code,
CPU time, and memory allocations.

Old struct generation
    BenchmarkQueryGovaluateSimple-4    2069 ns/op    992 B/op   25 allocs/op
    BenchmarkQueryGovaluateComplex-4   6212 ns/op   2544 B/op   75 allocs/op

New lazy json parsing
    BenchmarkQueryGovaluateSimple-4    1404 ns/op    320 B/op   18 allocs/op
    BenchmarkQueryGovaluateComplex-4   2617 ns/op    512 B/op   30 allocs/op

Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Simplify Get method.
d9d8234 
Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Fix complex query benchmark.
b561945 
Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Look up struct fields by name.
5a16dbe 
Reduces cost of querying in the most common case.

Refs #586
echlebek added a commit that referenced this issue Nov 23, 2017
@echlebek
Improve package ergonomics and fix a bug.
6a3137d 
* Break up Attributer interface into AttrGetter and AttrSetter.
* Get rid of the Attributes type in favour of simple []byte.
* Make AttrGetter method set match what protobuf might generate.
* When returning struct fields from GetField, use reflect.Indirect
  so that pointers are never returned.
* Make sure that extended attributes are never returned by GetField
  and never marshaled by Marshal.

Refs #586
@echlebek echlebek mentioned this issue Nov 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echlebek echlebek

Labels
1.x parity feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@echlebek