Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish previously working Strimzi RCO/SBO sample somewhere #3

Open
ron1 opened this issue Jul 9, 2020 · 8 comments
Open

Publish previously working Strimzi RCO/SBO sample somewhere #3

ron1 opened this issue Jul 9, 2020 · 8 comments

Comments

@ron1
Copy link

ron1 commented Jul 9, 2020

The previously working Strimzi RCO/SBO sample was quite useful for early adopters of RCO and SBO. As a result, consider publishing the previous version of the sample in its own branch in this repo or as a branch in sample-service-binding-kafka repo.

Also consider maintaining the sample as new RCO and SBO versions converge towards the new specification. It would be especially useful to know which versions of RCO and SBO were used to implement each working milestone.

@arthurdm
Copy link
Member

arthurdm commented Jul 9, 2020

I think a SBO-specific sample is a great idea, but would be better suited in the SBO repo - which allows for much better synchronization with SBO changes.

@ron1
Copy link
Author

ron1 commented Jul 9, 2020

In light of the following facts, would it not make more sense for such a sample to exist in an RCO application-stacks samples repo?

  • RCO application-stacks already maintains a bunch of similar service-binding samples (do you propose moving these as well?)
  • RCO CRD embeds an SBR highlighting the need to sync RCO releases w/SBO versions
  • Complex, production-like deployment of Kafka producer/consumer clients by RCO w/Strimzi Operator seems a bit complex for SBO to maintain

Thoughts?

@katheris
Copy link

For Strimzi specifically we are currently working with both the SBO and the Strimzi communities to agree and enable good integration. It would be useful to have this sample here so we can update it as the Strimzi and Service Binding operators evolve, at least until we believe the integration is reasonably complete.

@ron1
Copy link
Author

ron1 commented Jul 10, 2020

As of now the sample in this repo is based on the latest spec version which is significantly different from what is currently supported by the SBO. Another version of the sample is needed that works today and can evolve as the RCO and SBO evolve towards spec compliance. Where should this version of the sample reside? Today I believe the only copy of a working sample exists in this personal forked repo https://github.com/navidsh/service-binding-specification.

@scothis
Copy link
Member

scothis commented Jul 10, 2020

Today I believe the only copy of a working sample exists in this personal forked repo

Tagged releases are "forever"

@ron1
Copy link
Author

ron1 commented Jul 10, 2020

@scothis Does a tagged version of the working sample exist in a non-personal repo somewhere?

@ron1
Copy link
Author

ron1 commented Jul 10, 2020

@scothis OK. I see the spec repo has a tag with the working sample. Thanks.

@ron1
Copy link
Author

ron1 commented Jul 11, 2020

@katheris I believe a working version of the RCO/SBO Strimzi mTLS sample can be achieved today w/out any Strimzi code or Strimzi CSV changes using a combination of KafkaUser CR SBO annotations and setting SBR property detectBindingResources: true (to obtain the ca certificate w/out the need for this patch navidsh/strimzi-kafka-operator@dc0c3e1).

The sample that currently exists in this repo represents the "to be" solution. It would also seem useful to maintain the "as is" solution along with intermediate milestones as the solution evolves from "as is" to "to be". Would it make sense to track that evolution in another branch in this repo, say a "strimzi-working" branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants