Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera/Gallery Screens can be added to Stack Multiple Times. #13853

Open
3 tasks done
Sagar0-0 opened this issue Dec 24, 2024 · 1 comment · May be fixed by #13875
Open
3 tasks done

Camera/Gallery Screens can be added to Stack Multiple Times. #13853

Sagar0-0 opened this issue Dec 24, 2024 · 1 comment · May be fixed by #13875

Comments

@Sagar0-0
Copy link
Contributor

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

Steps to reproduce:

  1. Click on Camera from Chats Screen
  2. In camera screen Click on Gallery Option.
  3. In, gallery Option, Click on Top right Corner's Camera Icon.
  4. This will navigate the user to the same Camera screen.

Possible solutions:

  1. Do not show the Camera Icon in the galley, if the navigation was done from the Camera screen itself. Can be easily Implemented with a Flag. Same needs to be done for the camera screen, if the user is navigated to the camera screen FROM the Gallery screen then DO not show the gallery option.
  2. Use SingleTop LaunchModes for both the Camera and Gallery Screen. (Recommended).

I am ready with a PR, please assign this issue to me to proceed

Screenshots

document_6294060588427382986.mp4

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

NA
@Sagar0-0
Copy link
Contributor Author

After testing with different scenarios, it has been found that this

Do not show the Camera Icon in the galley, if the navigation was done from the Camera screen itself.

approach is convenient and does not disturb any other flows.

I am ready with a PR.

Sagar0-0 added a commit to Sagar0-0/Signal-Android that referenced this issue Jan 4, 2025
@Sagar0-0
Fixes signalapp#13853
4b44129
@Sagar0-0 Sagar0-0 linked a pull request Jan 4, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #13853 - Camera/Gallery Stack Sagar0-0/Signal-Android
1 participant
@Sagar0-0