Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit for Donation Amount #13872

Open
3 tasks done
Sagar0-0 opened this issue Jan 3, 2025 · 0 comments · May be fixed by #13877
Open
3 tasks done

Limit for Donation Amount #13872

Sagar0-0 opened this issue Jan 3, 2025 · 0 comments · May be fixed by #13877

Comments

@Sagar0-0
Copy link
Contributor

Sagar0-0 commented Jan 3, 2025 •
edited
Loading

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

Steps:

  1. Go to settings
  2. Go to Donation
  3. Select one-time Custom amount
  4. Enter a large amount

This can cause issues while making a payment and shows an edge case when entering the amount. (Like it causes Failure in case of PayPal)
A limit of 9 Characters is enough and won't fail for PayPal.
Please assign this to me I am ready with my PR

Screenshots

photo_6323106151331383439_y

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

NA
shahrukhahmed94 added a commit to shahrukhahmed94/Signal-Android that referenced this issue Jan 4, 2025
@shahrukhahmed94
Fix: Limit donation amount input to 9 characters (signalapp#13872)
c08af2e 
- Added validation in MoneyFilter to restrict input to 9 characters.
- Updated both filter and afterTextChanged methods to enforce this limit.
- Ensured edge cases and formatting remain functional.
- Resolves signalapp#13872.
@shahrukhahmed94 shahrukhahmed94 linked a pull request Jan 4, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Limit donation amount input to 9 characters (#13872) shahrukhahmed94/Signal-Android
1 participant
@Sagar0-0