Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smart pointers! #22

Open
shahzadlone opened this issue Feb 5, 2019 · 0 comments
Open

Use smart pointers! #22

shahzadlone opened this issue Feb 5, 2019 · 0 comments
Labels
C++11 The second set of patches patch Intended to be part of the patch series that makes up splinter

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Feb 5, 2019 •
edited
Loading

This is a big one! Use RAII styled pointers (smart pointers) where ever necessary.

Get rid of raw pointers! Perhaps a good way to do this would be to find every where new and delete are called to hunt these down (also please use make_unique or '''make_sharedrather thannew``` ( this will be a separate patch I guess.)

Please use unique_ptr unless absolutely need to use shared_ptr.

#23
@shahzadlone shahzadlone changed the title Use smart pointer's! Use smart pointers! Feb 5, 2019
@shahzadlone shahzadlone mentioned this issue Feb 5, 2019
Open
@shahzadlone shahzadlone changed the title Use smart pointers! Use smart pointers! [PATCH] Feb 5, 2019
@jonesmz jonesmz changed the title Use smart pointers! [PATCH] Use smart pointers! Feb 5, 2019
@jonesmz jonesmz added patch Intended to be part of the patch series that makes up splinter C++11 The second set of patches labels Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++11 The second set of patches patch Intended to be part of the patch series that makes up splinter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonesmz @shahzadlone