Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review @ConditionalOnProperty with spring.jmx.enabled #43706

Open
philwebb opened this issue Jan 7, 2025 · 0 comments
Open

Review @ConditionalOnProperty with spring.jmx.enabled #43706

philwebb opened this issue Jan 7, 2025 · 0 comments
Labels
for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged

Comments

@philwebb
Copy link
Member

philwebb commented Jan 7, 2025

We have a few @ConditionalOnProperty annotations that check for "spring.jmx" with matchIfMissing = true (e.g. org.springframework.boot.autoconfigure.integration.IntegrationAutoConfiguration.IntegrationJmxConfiguration).

Since commit ce9626d JmxAutoConfiguration does not have matchIfMissing, so I wonder if we should align all our conditions.
@philwebb philwebb added type: task A general task status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress and removed type: task A general task labels Jan 7, 2025
@snicoll snicoll changed the title Review @ConditionalOnProperty with spring.jmx Review @ConditionalOnProperty with spring.jmx.enabled Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philwebb