Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue on 35 target Sdk spot light position #192

Open
ahmed2146 opened this issue Jan 6, 2025 · 3 comments
Open

issue on 35 target Sdk spot light position #192

ahmed2146 opened this issue Jan 6, 2025 · 3 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@ahmed2146
Copy link

Describe the bug
when we change the target Sdk from 34 to 35, the position of the spotlight changes. The position will be moved down to the actual position. screenshots are attached

Version
com.svenjacobs.reveal:reveal-compat-android:3.1.1
com.svenjacobs.reveal:reveal-core:3.1.1

also not working on
com.svenjacobs.reveal:reveal-compat-android:3.0.5
com.svenjacobs.reveal:reveal-core:3.0.5

Target Sdk 34
target Sdk 34

Target Sdk 35
target Sdk 35

@ahmed2146 ahmed2146 added the bug Something isn't working label Jan 6, 2025
@svenjacobs
Copy link
Owner

Hello,

is this a native Compose app or do you embed Compose with ComposeView in a Fragment for example? If it's not a native Compose app please read the FAQ. I didn't notice this problem with a native Compose app. It's also probably related to the window inset changes since SDK 35.

@svenjacobs svenjacobs added the question Further information is requested label Jan 6, 2025
@ahmed2146
Copy link
Author

ahmed2146 commented Jan 7, 2025

i'm using the compose with this structure
RevealCanvas(
modifier = Modifier.fillMaxSize(),
revealCanvasState = revealCanvasState,
) {
Reveal()
{
Scaffold()
}
}

now I have to adjust the position by adding a native top,
can you share the steps to adjust the position by using the window inset,
as my application is working fine only I'm facing an issue in spot light "revealable" where overlayContent is fine

@svenjacobs
Copy link
Owner

Please share a full example application that reproduces this issue. Otherwise it's difficult to find out the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants