Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Plan Implementation - Integration Tests: swift-plugin #1230

Open
michael-weng opened this issue Nov 27, 2024 · 2 comments
Open

Test Plan Implementation - Integration Tests: swift-plugin #1230

michael-weng opened this issue Nov 27, 2024 · 2 comments
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases

Comments

@michael-weng
Copy link
Contributor

michael-weng commented Nov 27, 2024 •
edited
Loading

We already have integration tests for the task providers, but just need one to cover the user facing commands.

What we want to test for:

  • swift.runPluginTask shows up and can be executed by user when under the right command_plugin file
  • swift.runPluginTask command return appropriate tasks from different sources (provided by extension or resolved from tasks.json)
michael-weng added a commit to michael-weng/vscode-swift that referenced this issue Nov 27, 2024
@michael-weng
Add integration test for swift.runPluginTask command
51d270c 
- Change runPluginTask to return the argument filter for better testability
- Given SwiftPluginTaskProvider integration test already test the tasks,
assert the command arguments are valid and return the right tasks for
picking.

Issue: swiftlang#1230
@michael-weng michael-weng mentioned this issue Nov 27, 2024
Closed
michael-weng added a commit to michael-weng/vscode-swift that referenced this issue Nov 27, 2024
@michael-weng
Add integration test for swift.runPluginTask command
f404498 
- Change runPluginTask to return the argument filter for better testability
- Given SwiftPluginTaskProvider integration test already test the tasks,
assert the command arguments are valid and return the right tasks for
picking
- Minor clean up like removing redudant suite clean up and switch to use
constant enum

Issue: swiftlang#1230
@award999
Copy link
Contributor

@michael-weng can you add the plan of what needs to be tested

@award999 award999 added the testing infrastructure Issues related to CI jobs or extension test cases label Nov 29, 2024
@michael-weng
Copy link
Contributor Author

@michael-weng can you add the plan of what needs to be tested

Done.

@award999 award999 moved this from Unscreened to In Progress in Swift Extension for Visual Studio Code Dec 3, 2024
michael-weng added a commit to michael-weng/vscode-swift that referenced this issue Dec 3, 2024
@michael-weng
Add integration test for swift.runPluginTask command
8aa6e90 
- Change runPluginTask to return the argument filter for better testability
- Given SwiftPluginTaskProvider integration test already test the tasks,
assert the command arguments are valid and return the right tasks for
picking
- Minor clean up like removing redudant suite clean up and switch to use
constant enum

Issue: swiftlang#1230
award999 added a commit to award999/vscode-swift that referenced this issue Dec 10, 2024
@award999
Test for run plugin task command
af9fb24 
Will mock to verify correct command is called

Issue: swiftlang#1230
@award999 award999 mentioned this issue Dec 10, 2024
Merged
award999 added a commit to award999/vscode-swift that referenced this issue Dec 10, 2024
@award999
Test for run plugin task command
afd3070 
Will mock to verify correct command is called

Issue: swiftlang#1230
award999 added a commit that referenced this issue Dec 12, 2024
@award999
Test for run plugin task command (#1256)
c72b909 
Will mock to verify correct command is called

Issue: #1230
@award999 award999 added the needs verification Issue has been fixed, but requires verification before closing label Dec 12, 2024
@award999 award999 moved this from In Progress to Needs Verification in Swift Extension for Visual Studio Code Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases
Projects
Swift Extension for Visual Studio Code
Status: Needs Verification
Milestone
No milestone
Development

No branches or pull requests
2 participants
@award999 @michael-weng