Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths is always allowed #69

Open
JanPetterMG opened this issue Jul 26, 2016 · 1 comment
Open

Relative paths is always allowed #69

JanPetterMG opened this issue Jul 26, 2016 · 1 comment
Labels
Milestone

Comments

@JanPetterMG
Copy link
Collaborator

User-agent: *
Disallow: /
$this->assertTrue($parser->isDisallowed("&&1@|"));
$this->assertFalse($parser->isAllowed('+£€@@1¤'));

The two tests above fails, paths allowed according to the parser, the robots.txt says otherwise...

At least the second one could also be an potential relative path, so we can't just ignore this bug either, we have to fix it...

@JanPetterMG
Copy link
Collaborator Author

Also applies to:

$this->assertFalse($parser->isAllowed('path'));
$this->assertFalse($parser->isAllowed('*wildcard'));

I'm not sure why I didn't test that earlier... 😕 This is no longer an low-priority issue, but an huge and prioritized one!

@JanPetterMG JanPetterMG added this to the v0.3.0 milestone Jul 27, 2016
@JanPetterMG JanPetterMG changed the title Relative path bug Relative paths is always allowed Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant