-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings of test not wrapped in act since 9.3.2 #1275
Comments
Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check your issue body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
Hi @joaopedrodcf. |
Wow, that was really quick @MatanBobi :D Yeah, it was getting duplicated like this! After removing it, it works again 🥇 I think I saw it in next documentation but tried to look again but can't find it anymore maybe they updated their docs 😆 Gonna close the issue |
Actually found the reason @MatanBobi why I add installed the In the docs of user-event they say that we need to install it: Even yarn will say that a peer dep is not met if we don't install it |
Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check #1275 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
1 similar comment
Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check #1275 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
Uh oh! @joaopedrodcf, the image you shared is missing helpful alt text. Check #1275 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
We have an open PR to remove that: testing-library/testing-library-docs#1329 |
Thank you so much 🙏 |
@testing-library/dom
version: 9.3.2 or greaterRelevant code or config:
What you did:
Upgraded from 9.3.1 to 9.3.2
What happened:
The warnings started appearing all over the place
Reproduction:
Problem description:
Upgrading from
"@testing-library/dom": "9.3.1",
to `"@testing-library/dom": "9.3.2" will start showing warnings in almost every test.All the warnings are related with not wrapping in act.
Suggested solution:
I don't have suggested solution as I never checked the codebase of dom testing library, probably something changed from version 9.3.1 to 9.3.2
The text was updated successfully, but these errors were encountered: