fix: avoid reporting react-test-renderer utils as queries
#709
Conversation
| return ( | ||
| isQuery(node) && | ||
| node.name.startsWith('find') && | ||
| !EXCLUDED_FIND_BY_QUERIES.includes(node.name) |
There was a problem hiding this comment.
Actually... I could add this to isQuery instead.
| 'findByType', | ||
| 'findByProps', | ||
| 'findAll', | ||
| 'findAllByType', | ||
| 'findAllByProps', |
There was a problem hiding this comment.
And what if someone uses a custom query with one of these names? We still want them to be reported. no? How can we make sure that we are dealing with a react-test-renderer query?
This relates also to this comment.
There was a problem hiding this comment.
That would be the ideal fix indeed. However, since the utils names seem quite specific and can be chained from built-in queries in React Native, this PR could be a quick workaround.
I personally don't have the time to implement the ideal fix to check if queries are coming from react-test-renderer, so it's a matter of deciding if we are happy with this workaround (and its trade-offs) or we are only interested in the ideal fix.
There was a problem hiding this comment.
Another idea could be adding a config for React Native to the plugin, which adds automatically the corresponding query names to the settings to be ignored as custom queries.
This would be a workaround too, but perhaps makes more sense since it would affect just users using the RN preset.
|
Thinking about this again... this doesn't make sense. I'll close this PR and update the issue to mention how the ideal fix should look like and a temporary workaround for those React Native users running into false positives. |
Checks
Changes
react-test-rendererutils asfind*queriesreact-test-rendererutils as custom queriesContext
Fixes #671
Fixes #673