Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Code clean up #372

Open
TylerGillson opened this issue Sep 11, 2024 · 1 comment
Open

🎨 Code clean up #372

TylerGillson opened this issue Sep 11, 2024 · 1 comment
Labels
enhancement Enhancement to an existing feature

Comments

@TylerGillson
Copy link
Member

TylerGillson commented Sep 11, 2024

Summary

We still have unnecessary code pertaining to VMs and YAML marshalling/unmarshalling for vCenter entities. It would be good to tidy it up at some point.

We should make entity.Entity a string 🤦🏼

Any removals must be cross-checked against validatorctl, since it also relies on the VCenterDriver.

@TylerGillson TylerGillson added the enhancement Enhancement to an existing feature label Sep 11, 2024
Copy link

dosubot bot commented Dec 11, 2024

Hi, @TylerGillson. I'm Dosu, and I'm helping the validator-plugin-vsphere team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue proposes refactoring and removing redundant code related to VMs and YAML marshalling/unmarshalling for vCenter entities.
  • Suggests converting entity.Entity to a string format.
  • Emphasizes the need to ensure compatibility with validatorctl, which depends on VCenterDriver.
  • No comments or further activity have been made on this issue.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the validator-plugin-vsphere repository by commenting here.
  • If there is no further input, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 11, 2024
@TylerGillson TylerGillson removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant