Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capitalization in architecture diagrams #1734

Open
javamyth opened this issue Apr 26, 2024 · 3 comments
Open

Fix capitalization in architecture diagrams #1734

javamyth opened this issue Apr 26, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@javamyth
Copy link

javamyth commented Apr 26, 2024 •
edited by deepthi
Loading

Question

Why are V, T, and G in VTGate in the architecture diagram in uppercase, V, T, and T in VTablet in uppercase, V, T, and A in VTAdmin in uppercase, while vtctld and vtorc are all lowercase.Please explain, thank you
architecture
@javamyth javamyth changed the title About capitalization in architecture diagrams Question : About capitalization in architecture diagrams Apr 26, 2024
@deepthi deepthi transferred this issue from vitessio/vitess Apr 26, 2024
@deepthi deepthi changed the title Question : About capitalization in architecture diagrams Fix capitalization in architecture diagrams Apr 26, 2024
@deepthi deepthi added the good first issue Good for newcomers label Apr 26, 2024
@deepthi
Copy link
Member

deepthi commented Apr 26, 2024

We should fix the diagram so that vtctld and vtorc are also capitalized consistently. Not a high priority, so can be done the next time we update the diagram for other reasons.

@shivamgupta2020
Copy link

shivamgupta2020 commented May 15, 2024 •
edited
Loading

architecture_new
@deepthi will this diagram work?

@deepthi
Copy link
Member

deepthi commented Jan 3, 2025

@shivamgupta2020 apologies, I never saw your comment. If you are still interested in working on this, yes that looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deepthi @javamyth @shivamgupta2020