-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection name does not always auto capitalize the first letter #6549
Collection name does not always auto capitalize the first letter #6549
Comments
@tsmith023 can I pick this up? |
@melsonic, please do! I'd be happy to review the PR if you @ me on it once ready 😁 |
Sure thing @tsmith023 🚀🚀🚀 Meanwhile, I have another open PR, could you please review that one if possible? |
Hi @tsmith023, I have gone through the codebase both (weaviate core & weaviate-python-client). Based on that I believe the auto-capitalize functionality is implemented in weaviate-python-client. As for all the 3 methods mentioned, I could see the function So, I believe I would need to auto-capitalize the first letter under |
Weaviate auto capitalizes the first letter when creating a collection, as it follows the GraphQL naming conventions. However, it does not auto capitalize the first letter in some other situations.
Example
✔️
client.collections.create(name="test")
-> creates collectionTest
✔️
client.collections.delete("test")
-> deletes collectionTest
✔️
client.collections.get("test")
-> gets collectionTest
❌
Filter.by_ref_multi_target("hasQuestion", target_collection="test")
-> does not work because it looks fortest
and notTest
Expected behavior
I expect that the first letter is always auto capitalized when working with collections for consistency (and less debugging).
I used the weaviate-python-client for testing. If the auto capitalization is made in Weaviate, please transfer this issue accordingly.
The text was updated successfully, but these errors were encountered: