Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac profiler compilation error (jthread, stop_token) (+ temp fix) #964

Open
Mala9898 opened this issue Jan 5, 2025 · 1 comment
Open

Comments

@Mala9898
Copy link

Mala9898 commented Jan 5, 2025

Clang does not suport jthread
include/ppqsort/parallel/cpp/mainloop_par.h:138:58: error: no member named 'jthread' in namespace 'std'; did you mean 'thread'? 138 | int threads = static_cast<int>(std::jthread::hardware_concurrency())) { | ~~~~~^~~~~~~ | thread

this introduces the problem
1c1faef

a fix is waiting to be merged
GabTux/PPQSort#1

But in meantime the easiest workaround is to use this commit
git checkout 684c34dc21e123b608e962d026d8c40ff0abe5ee

Hopefully this saves any reader from wasting an entire morning on messing with toolchains

@foxtran
Copy link
Contributor

foxtran commented Jan 6, 2025

My patch is really stupid. It does not support a proper cancellation if main thread of program was stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants