Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contenteditable delete removes source #3

Open
nwtn opened this issue Apr 17, 2013 · 2 comments
Open

contenteditable delete removes source #3

nwtn opened this issue Apr 17, 2013 · 2 comments

Comments

@nwtn
Copy link

nwtn commented Apr 17, 2013

In a contenteditable element, when the caret immediately precedes a <picture><source /></picture>, hitting delete or calling document.execCommand('Delete') removes the <source>.
@yoavweiss
Copy link
Owner

Can you put up an example? Which test does this refer to?

@nwtn
Copy link
Author

nwtn commented Apr 17, 2013

It's this one.

yoavweiss pushed a commit that referenced this issue Jun 22, 2013
Remove MediaStreamDescriptor and call/use WebMediaStream directly (at…
8e7c7ab 
…tempt #3)

Previous attempts: https://codereview.chromium.org/16366004/ , https://codereview.chromium.org/16865014/

BUG=

Review URL: https://chromiumcodereview.appspot.com/17063005

git-svn-id: svn://svn.chromium.org/blink/trunk@152913 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 23, 2013
Revert "Remove MediaStreamDescriptor and call/use WebMediaStream dire…
6b5ecc1 
…ctly (attempt #3)" (r152913).

Speculative revert to fix VideoDestination browser_tests failures.

(Sorry if this turns out to be a mis-fire).

[email protected]
BUG=

Review URL: https://codereview.chromium.org/17553017

git-svn-id: svn://svn.chromium.org/blink/trunk@152926 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jul 11, 2013
Revert "Rewrite parseFrameSetListOfDimension to match HTML5"
41ba31c 
The change has resulted in ASAN failures:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/7635/steps/webkit_tests/logs/stdio

==2535==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000176835 at pc 0x5b315d5 bp 0x7fffeec0d570 sp 0x7fffeec0d568
READ of size 1 at 0x604000176835 thread T0 (content_shell)
       #0 0x5b315d4 in WebCore::Length WebCore::parseDimension<unsigned char>(unsigned char const*, unsigned long, unsigned long) ../third_party/WebKit/Source/core/html/HTMLDimension.cpp:62:0
       #1 0x5b3111b in WebCore::parseDimension(WTF::String const&, unsigned long, unsigned long) ../third_party/WebKit/Source/core/html/HTMLDimension.cpp:97:0
       #2 0x5b30fab in WebCore::parseListOfDimensions(WTF::String const&) ../third_party/WebKit/Source/core/html/HTMLDimension.cpp:129:0
       #3 0x5a4ae7f in WebCore::HTMLFrameSetElement::parseAttribute(WebCore::QualifiedName const&, WTF::AtomicString const&) ../third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp:84:0

This reverts commit ac7e5c0.

[email protected]

Review URL: https://codereview.chromium.org/18565005

git-svn-id: svn://svn.chromium.org/blink/trunk@154013 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jul 29, 2013
[CSS Shapes] Port shape-inside on regions and shape's content overflo…
9d3c595 
…w from WebKit

This change covers a set of smaller fixes that were landed in WebKit regarding to shape-inside on regions and content overflow from shape-inside.

Merged revisions:
- #1  http://trac.webkit.org/changeset/148975
- #2  http://trac.webkit.org/changeset/149857
- #3  http://trac.webkit.org/changeset/150027
- #4  http://trac.webkit.org/changeset/150375
- #5  http://trac.webkit.org/changeset/150478
- #6  http://trac.webkit.org/changeset/151570
- #7  http://trac.webkit.org/changeset/151652
- #8  http://trac.webkit.org/changeset/151703
- #9  http://trac.webkit.org/changeset/152772
- #10 http://trac.webkit.org/changeset/152904
- #11 http://trac.webkit.org/changeset/152906
- #12 http://trac.webkit.org/changeset/152925
- #13 http://trac.webkit.org/changeset/153053

[email protected]
BUG=262269

Review URL: https://chromiumcodereview.appspot.com/19865002

git-svn-id: svn://svn.chromium.org/blink/trunk@155098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 13, 2013
Remove block content clips where we can show that they are unnecessary.
70f2c26 
This CL:
1. Modifies RenderBlock::computeOverflow to track, in addition to the visual overflow of the element itself, a bounding rect for the visual overflow of its contents. All call sites of addVisualOverflow are modified to declare whether the visual overflow is affected by the contents clip or not.
2. Modifies RenderBox::pushContentsClip to use this rect to determine whether the contents are visually contained by the clip, in which case it omits the clip.

See measurements in my comment #3 on the bug: https://code.google.com/p/chromium/issues/detail?id=238732#c3

BUG=238732
[email protected]

Review URL: https://codereview.chromium.org/16402019

git-svn-id: svn://svn.chromium.org/blink/trunk@155847 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Feb 2, 2014
Use PartitionAlloc for fastMalloc on Android
3b994c5 
This switches fastMalloc to PartitionAlloc for Android. Previously, we only
used PartitionAlloc for fastMalloc on Mac OS X.

According to primiano's measurements, this CL should improve PLT performance
on Android by 7%.  See referenced bug for details.

alexa_us on N10 with default alloc (without
#     ms/page  PSS   Dirty
#1    227.6   60410 44904
#2    226.1   61547 46008
#3    222.4   55595 40072
#4    224.2   57293 41728
AVG   225.1   58711 43178

alexa_us on N10 with partalloc
#     ms/page  PSS   Dirty
#1    204.68  54862  39456
#2    208.73  59240  43844
#3    208.57  55164  39788
#4    217.28  58280  42904
AVG   209.81  56886  41498

BUG=312725
[email protected]

Review URL: https://codereview.chromium.org/148013010

git-svn-id: svn://svn.chromium.org/blink/trunk@166271 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Feb 5, 2014
Fixed crash on Android tcmalloc builds caused by vasprintf being inco…
311405a 
…mpatible to tcmalloc

[email protected]
TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash.

********** Crash dump: **********
Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys'
pid: 3431, tid: 3444  >>> org.chromium.content_shell_apk:sandboxed_process1 <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039
Stack frame #00  pc 02263b44  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15
Stack frame #1  pc 0226ccd8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120
Stack frame #2  pc 0227584c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0
Stack frame #3  pc 02277698  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166
Stack frame #4  pc 02277898  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209
Stack frame #5  pc 0229f914  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569
Stack frame #6  pc 0158af50  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0
Stack frame #7  pc 0158aff8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305
Stack frame #8  pc 01166dac  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572
Stack frame #9  pc 0116b7a8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0
Stack frame #10  pc 0117e424  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453
Stack frame #11  pc 0117ea88  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767
Stack frame #12  pc 0158891c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0
Stack frame #13  pc 01589da0  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876
Stack frame #14  pc 01589f3c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49
Stack frame #15  pc 00d07e70  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70
Stack frame #16  pc 015770bc  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70
Stack frame #17  pc 017bdd20  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47
Stack frame #18  pc 017bddc8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219
Stack frame #19  pc 00eb86d8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110
Stack frame #20  pc 01024b5c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443
Stack frame #21  pc 010304c8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971
Stack frame #22  pc 010305dc  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845
Stack frame #23  pc 00fb12f8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875
Stack frame #24  pc 00fb1b78  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076
Stack frame #25  pc 00fb1bd0  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0

Review URL: https://codereview.chromium.org/143903018

git-svn-id: svn://svn.chromium.org/blink/trunk@166520 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 27, 2014
Revert of Make start/stop loading notifications per-frame (https://co…
d6b8933 
…dereview.chromium.org/183793002/)

Reason for revert:
Possibly causing content_browsertests EndToEnd to fail.

See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio

Output:
[20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0)
[20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28)
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x000000a593be base::debug::StackTrace::StackTrace()
#1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f9c3e4ab4a0 <unknown>
#3 0x7f9c3e55da43 __poll
#4 0x7f9c42aabff6 <unknown>
#5 0x7f9c42aac124 g_main_context_iteration
#6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher()
#7 0x000000a8e802 base::RunLoop::Run()
#8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread()

Original issue's description:
> Make start/stop loading notifications per-frame
> 
> Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly.
> 
> This depends on https://codereview.chromium.org/180113003/ landing in chromium.
> 
> BUG=347643
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=347643

Review URL: https://codereview.chromium.org/215533004

git-svn-id: svn://svn.chromium.org/blink/trunk@170218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 28, 2014
Revert of Revert of Make start/stop loading notifications per-frame (h…
28a1ff6 
…ttps://codereview.chromium.org/215533004/)

Reason for revert:
r170192 was not a culprit.


Original issue's description:
> Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/)
> 
> Reason for revert:
> Possibly causing content_browsertests EndToEnd to fail.
> 
> See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio
> 
> Output:
> [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0)
> [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28)
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x000000a593be base::debug::StackTrace::StackTrace()
> #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #2 0x7f9c3e4ab4a0 <unknown>
> #3 0x7f9c3e55da43 __poll
> #4 0x7f9c42aabff6 <unknown>
> #5 0x7f9c42aac124 g_main_context_iteration
> #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher()
> #7 0x000000a8e802 base::RunLoop::Run()
> #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread()
> 
> Original issue's description:
> > Make start/stop loading notifications per-frame
> > 
> > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly.
> > 
> > This depends on https://codereview.chromium.org/180113003/ landing in chromium.
> > 
> > BUG=347643
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192
> 
> [email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=347643
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170218

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=347643

Review URL: https://codereview.chromium.org/216083002

git-svn-id: svn://svn.chromium.org/blink/trunk@170248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 28, 2014
Revert of Make DOMWrapperWorld::current() return a reference instead …
0f588d3 
…of a pointer (https://codereview.chromium.org/209713003/)

Also reverting dependent patch https://codereview.chromium.org/213543004

Reason for revert:
Likely to have caused memory leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1

(1)
Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
    #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
    #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
    #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132

(2)
Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
    #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
    #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
 
(3)
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
    #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533
    #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549
    #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125
    #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175
    #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53

Original issue's description:
> Make DOMWrapperWorld::current() return a reference instead of a pointer
> 
> Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer.
> 
> BUG=341032
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=341032

Review URL: https://codereview.chromium.org/217053007

git-svn-id: svn://svn.chromium.org/blink/trunk@170357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Mar 31, 2014
Revert 170357 "Revert of Make DOMWrapperWorld::current() return ..."
8961684 
This is a revert of the revert of r170261.
r170261 was reverted because it introduced new memory leaks, but the leaks were false-positive.

> Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/)
> 
> Also reverting dependent patch https://codereview.chromium.org/213543004
> 
> Reason for revert:
> Likely to have caused memory leaks:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1
> 
> (1)
> Direct leak of 32 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
>     #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
>     #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
>     #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
> 
> (2)
> Indirect leak of 40 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
>     #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
>     #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
>  
> (3)
> Indirect leak of 24 byte(s) in 1 object(s) allocated from:
>     #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
>     #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533
>     #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549
>     #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125
>     #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175
>     #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
> 
> Original issue's description:
> > Make DOMWrapperWorld::current() return a reference instead of a pointer
> > 
> > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer.
> > 
> > BUG=341032
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261
> 
> [email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=341032
> 
> Review URL: https://codereview.chromium.org/217053007

[email protected]

Review URL: https://codereview.chromium.org/218813002

git-svn-id: svn://svn.chromium.org/blink/trunk@170424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 12, 2014
Handle initial values in background-repeat introduced by the backgrou…
05eca13 
…nd shorthand

background-repeat serialization did not handle initial keyword values in
background-repeat value lists.
Initial values in value lists are introduced by setting the background
shorthand to multiple background values while omitting background-repeat
properties.
Example: background: url(#1), url(#2), url(#3);
The background-repeat gets stored internally as "initial, initial, initial".

This patch updates StylePropertySerializer::backgroundRepeatPropertyValue()
to handle this case correctly.

BUG=378167

Review URL: https://codereview.chromium.org/303993003

git-svn-id: svn://svn.chromium.org/blink/trunk@175261 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 12, 2014
ServiceWorker: Add a Response ctor that accepts the body as a Blob
18fe14c 
This ctor is expected to be added to the spec:
w3c/ServiceWorker#192

Eventually we'll also have ctors for String, Stream, and
ArrayBuffer bodies.

Multi-sided patch to implement blob-type fetch event
response bodies:
#1: blink-side, THIS PATCH
#2: chromium-side: https://codereview.chromium.org/304153015/
#3: blink-side: https://codereview.chromium.org/304233017

BUG=379074

Review URL: https://codereview.chromium.org/307063002

git-svn-id: svn://svn.chromium.org/blink/trunk@175350 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 12, 2014
MediaStream API: Patch #3 of implementing navigator.getMediaDevices
70b600d 
Adds idl files and tests.

Initial patch (1) by tommyw@ from https://codereview.chromium.org/145583015/

BUG=338511

Review URL: https://codereview.chromium.org/286673003

git-svn-id: svn://svn.chromium.org/blink/trunk@175469 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 16, 2014
Revert of IDL: Support optional argument default value syntax (https:…
4a1fd1c 
…//codereview.chromium.org/312683005/)

Reason for revert:
This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905

BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
#1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f2c232cd4a0 \u003Cunknown>
#3 0x7f2c2337f313 __poll
#4 0x7f2c240b6036 \u003Cunknown>
#5 0x7f2c240b6164 g_main_context_iteration
#6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
#7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
#8 0x7f2c2a2f69d8 base::RunLoop::Run()
#9 0x00000466bd59 content::RunThisRunLoop()
#10 0x00000466c1b8 content::MessageLoopRunner::Run()
#11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
#12 0x0000011fdf00 MediaBrowserTest::RunTest()
#13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
#14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
#15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
#16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
...

Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.

Original issue's description:
> IDL: Support optional argument default value syntax
> 
> Adds support for parsing default values of different types, but
> only handles null default values when generating code.
> 
> Replaces existing
> 
>   [Default=Null] optional SomeInterface arg
>   [Default=NullString] optional DOMString arg
> 
> with the now equivalent
> 
>   optional SomeInterface arg = null
>   optional DOMString arg = null
> 
> in IDL files, and drops support for those [Default] attributes.
> 
> No changes to generated code.
> 
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339683002

git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Jun 16, 2014
Revert of Revert of IDL: Support optional argument default value synt…
356a3bd 
…ax (https://codereview.chromium.org/339683002/)

Reason for revert:
Revert the revert because the bot went green even without this revert, and other bots had no trouble.

Original issue's description:
> Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/)
> 
> Reason for revert:
> This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905
> 
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
> #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #2 0x7f2c232cd4a0 \u003Cunknown>
> #3 0x7f2c2337f313 __poll
> #4 0x7f2c240b6036 \u003Cunknown>
> #5 0x7f2c240b6164 g_main_context_iteration
> #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
> #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
> #8 0x7f2c2a2f69d8 base::RunLoop::Run()
> #9 0x00000466bd59 content::RunThisRunLoop()
> #10 0x00000466c1b8 content::MessageLoopRunner::Run()
> #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
> #12 0x0000011fdf00 MediaBrowserTest::RunTest()
> #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
> #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
> #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
> #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
> ...
> 
> Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.
> 
> Original issue's description:
> > IDL: Support optional argument default value syntax
> > 
> > Adds support for parsing default values of different types, but
> > only handles null default values when generating code.
> > 
> > Replaces existing
> > 
> >   [Default=Null] optional SomeInterface arg
> >   [Default=NullString] optional DOMString arg
> > 
> > with the now equivalent
> > 
> >   optional SomeInterface arg = null
> >   optional DOMString arg = null
> > 
> > in IDL files, and drops support for those [Default] attributes.
> > 
> > No changes to generated code.
> > 
> > BUG=258153
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200
> 
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339723002

git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Aug 20, 2014
Revert of DevTools: add initial support for console.time/timeEnd in t…
d797af1 
…racing based Timeline (patchset #3 of https://codereview.chromium.org/464063008/)

Reason for revert:
As per comment from nduca. I also don't understand why instrumentation is not reused.

Original issue's description:
> DevTools: add initial support for console.time/timeEnd in tracing based Timeline
> 
> console.time/timeEnd will result in instant trace events. The events will be shown as marker events, i.e. as markers on the Timeline overview.
> 
> BUG=361045
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180635

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=361045

Review URL: https://codereview.chromium.org/485893006

git-svn-id: svn://svn.chromium.org/blink/trunk@180640 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 8, 2014
@mounirlamouri
Revert of remove more redundant calls to drawingContext (patchset #3 of
21de36e 
https://codereview.chromium.org/503263002/)

Reason for revert:
this is breaking builds widely:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/91456/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/53993/steps/compile/logs/stdio

Original issue's description:
> remove more redundant calls to drawingContext
> 
> To call CanvasRenderingContext2D::drawingContext is not cheap. This function 
> checks whether the context is lost, whether the imagebuffer surface is valid.
> 
> Data from Linux perf tool for Canvas2D benchmarks (FishIETank, SpeedReading, 
> Galactic, GM3 vector and bitmap...) shows that rotate/translate/scale/clip 
> are frequently called per frame. However, these APIs call drawingContext twice. 
> As a result, drawingContext costs 2% ~ 7% of the whole render process in these 
> benchmarks. 
> 
> This simple CL makes rotate/translate/scale/clip/... pass GraphicsContext 
> to realizeSaves() if these callers can. The CL removes redundant calls of 
> drawingContext() to improve performance.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180985

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/489243003

git-svn-id: svn://svn.chromium.org/blink/trunk@180986 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 8, 2014
@mounirlamouri
Revert of ServiceWorker: throw when close() or terminate() called (pa…
1471064 
…tchset #3 of https://codereview.chromium.org/505063002/)

Reason for revert:
Break compilation on various bots. Maybe Win only.

Original issue's description:
> ServiceWorker: throw when close() or terminate() called
> 
> Per spec:
> * ServiceWorker#terminate() should throw InvalidAccessError
> * ServiceWorkerGlobalScope#close() should throw InvalidAccessError
> 
> ... since the behaviors inherited from the base interfaces are not
> supported.
> 
> Spec: slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html
> 
> BUG=398318
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181049

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=398318

Review URL: https://codereview.chromium.org/515323002

git-svn-id: svn://svn.chromium.org/blink/trunk@181050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 8, 2014
@inexorabletash
Revert of Revert of ServiceWorker: throw when close() or terminate() …
5547e68 
…called (patchset #1 of https://codereview.chromium.org/515323002/)

Reason for revert:
The CL reverted by this patchset was not responsible for the breakage. Re-landing.

Original issue's description:
> Revert of ServiceWorker: throw when close() or terminate() called (patchset #3 of https://codereview.chromium.org/505063002/)
> 
> Reason for revert:
> Break compilation on various bots. Maybe Win only.
> 
> Original issue's description:
> > ServiceWorker: throw when close() or terminate() called
> > 
> > Per spec:
> > * ServiceWorker#terminate() should throw InvalidAccessError
> > * ServiceWorkerGlobalScope#close() should throw InvalidAccessError
> > 
> > ... since the behaviors inherited from the base interfaces are not
> > supported.
> > 
> > Spec: slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html
> > 
> > BUG=398318
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181049
> 
> [email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=398318
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181050

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=398318

Review URL: https://codereview.chromium.org/513353002

git-svn-id: svn://svn.chromium.org/blink/trunk@181057 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 8, 2014
Revert of Implement DOMWrapperWorld::DOMObjectHolder (patchset #3 id:…
283b38d 
…40001 of https://codereview.chromium.org/512703007/)

Reason for revert:
Broke Linux oilpan build:

http://build.chromium.org/p/chromium.perf/builders/Linux%20Oilpan%20Builder/builds/5702

../../third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp:61:150: error: use of undeclared identifier 'callbackData'
    V8DOMWrapper::setNativeInfoWithPersistentHandle(wrapper, &V8InjectedScriptHost::wrapperTypeInfo, V8InjectedScriptHost::toInternalPointer(host), &callbackData->host);

Original issue's description:
> Implement DOMWrapperWorld::DOMObjectHolder
> 
> We sometimes need to keep a DOM object X alive while a V8 object Y is alive.
> If Y is a wrapper of X and we want to create only one wrapper for X,
> we can just use DOMDataStore. However, in some rare cases this condition
> doesn't hold, and in that case we need a separate mechanism.
> 
> InjectedScriptManager is one example, and it implements manual lifetime
> management using InjectedScriptManager::CallbackData.
> 
> This CL generalizes the mechanism and move it to DOMWrapperWorld::DOMObjectHolder.
> This is because I want to use the mechanism for ThenFunctions in serviceworkers/.
> 
> The semantics of DOMWrapperWorld::DOMObjectHolder is as follows:
> 
> - By calling DOMObjectHolder::create(T* object, Handle<Object> wrapper),
> you can create a holder that keeps the |object| alive as long as
> (1) the |wrapper| is alive or (2) the DOMWrapperWorld which the |wrapper| belongs to
> is disposed.
> 
> - By calling DOMWrapperWorld::registerDOMObjectHolder(DOMObjectHolderBase* holder),
> you can ask the DOMWrapperWorld to manage the lifetime of the holder.
> 
> BUG=340522
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181085

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=340522

Review URL: https://codereview.chromium.org/515403003

git-svn-id: svn://svn.chromium.org/blink/trunk@181109 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 8, 2014
@mwenge
Revert of Layout children if the width available to them has changed …
8071f99 
…(patchset #3 id:40001 of https://codereview.chromium.org/390633004/)

Reason for revert:
The CL was landed with unrelated changes. Reverting so that the corrected CL can be landed cleanly.

Original issue's description:
> Layout children if the width available to them has changed
> 
> Currently we let a style change to border or padding trigger a layout to
> children, even if the parent's width hasn't changed. This is because the
> change in border/padding alters the amount of space available to the children.
> 
> Likewise if a box has percent padding and uses border-box sizing then the
> space available to children can reduce/increase even when the box itself
> doesn't change size (e.g. because it has a max-width). When that happens we
> still need to relayout its children so they fit to the changed available width.
> 
> If we cached content width or even padding we could watch for changes to this
> available width for children but unfortunately we do neither so both of the
> above cases have to be identified specifically at layout time.
> 
> BUG=391820
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178864

[email protected]
BUG=391820

Review URL: https://codereview.chromium.org/529803002

git-svn-id: svn://svn.chromium.org/blink/trunk@181199 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 11, 2014
@jianli-chromium
Revert of Split out CSSParser public API (patchset #3 id:40001 of htt…
a85c412 
…ps://codereview.chromium.org/566483002/)

Reason for revert:
Caused compiling errors.

Original issue's description:
> Split out CSSParser public API
> 
> This patch separates the public API of BisonCSSParser from the hundreds
> of public methods it exposes. The plan is to build a new parser based on
> the css-syntax specification, which will eventually complete replace the
> bison-based parser. The functions in this class will do the run-time
> switching between the bison parser and the new (unwritten) parser.
> 
> For the functions here which are only ever used with a newly instantiated
> BisonCSSParser, I've moved instantiation to inside the CSSParser so that
> the functions can be static.
> 
> This is an updated version of a patch by eseidel from 8 months ago:
> https://codereview.chromium.org/112933010/
> 
> BUG=330389
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=330389

Review URL: https://codereview.chromium.org/566703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 11, 2014
@jianli-chromium
Revert of Revert of Split out CSSParser public API (patchset #1 id:1 of
a6d61db 
https://codereview.chromium.org/566703002/)

Reason for revert:
Bring it back since the OilPan builder is not a tree closer.

Original issue's description:
> Revert of Split out CSSParser public API (patchset #3 id:40001 of https://codereview.chromium.org/566483002/)
> 
> Reason for revert:
> Caused compiling errors.
> 
> Original issue's description:
> > Split out CSSParser public API
> > 
> > This patch separates the public API of BisonCSSParser from the hundreds
> > of public methods it exposes. The plan is to build a new parser based on
> > the css-syntax specification, which will eventually complete replace the
> > bison-based parser. The functions in this class will do the run-time
> > switching between the bison parser and the new (unwritten) parser.
> > 
> > For the functions here which are only ever used with a newly instantiated
> > BisonCSSParser, I've moved instantiation to inside the CSSParser so that
> > the functions can be static.
> > 
> > This is an updated version of a patch by eseidel from 8 months ago:
> > https://codereview.chromium.org/112933010/
> > 
> > BUG=330389
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825
> 
> [email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=330389
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181837

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=330389

Review URL: https://codereview.chromium.org/563893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 16, 2014
@wangxianzhu
Revert of Temporarily let DocumentMakerController use invalidatePaint…
8cf26bc 
…ForWholeRenderer (patchset #3 id:60001 of https://codereview.chromium.org/499493003/)

Reason for revert:
We have fixed the RenderText invalidation issue (crbug.com/394133).

Original issue's description:
> Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer
> 
> setShouldDoFullPaintInvalidation doesn't work for RenderText yet.
> 
> BUG=405501
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180877

[email protected],[email protected],[email protected]
BUG=405501

Review URL: https://codereview.chromium.org/574773002

git-svn-id: svn://svn.chromium.org/blink/trunk@182089 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 17, 2014
@wangxianzhu
Revert of Revert of Temporarily let DocumentMakerController use inval…
e3356ec 
…idatePaintForWholeRenderer (patchset #2 id:70001 of https://codereview.chromium.org/574773002/)

Reason for revert:
The RenderText change needs to be reverted because it causes failure of some chromium browsertest. 

Original issue's description:
> Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (patchset #3 id:60001 of https://codereview.chromium.org/499493003/)
> 
> Reason for revert:
> We have fixed the RenderText invalidation issue (crbug.com/394133).
> 
> Original issue's description:
> > Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer
> > 
> > setShouldDoFullPaintInvalidation doesn't work for RenderText yet.
> > 
> > BUG=405501
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180877
> 
> [email protected],[email protected],[email protected]
> BUG=405501
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182089

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=405501

Review URL: https://codereview.chromium.org/574913002

git-svn-id: svn://svn.chromium.org/blink/trunk@182126 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 18, 2014
@wangxianzhu
Revert of Temporarily let DocumentMakerController use invalidatePaint…
9837810 
…ForWholeRenderer (patchset #3 id:60001 of https://codereview.chromium.org/499493003/)

Reason for revert:
We have fixed the RenderText invalidation issue (crbug.com/394133).

Original issue's description:
> Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer
> 
> setShouldDoFullPaintInvalidation doesn't work for RenderText yet.
> 
> BUG=405501
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180877

[email protected],[email protected],[email protected]
BUG=405501

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182089

Review URL: https://codereview.chromium.org/574773002

git-svn-id: svn://svn.chromium.org/blink/trunk@182181 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 20, 2014
@dpranke
Try #3 to fix the android layout tests crash in run-webkit-tests.
920aa70 
This patch forcibly reencodes to ASCII at a different layer, matching
where we're actually seeing the stack trace. This seems like an
overly broad solution, but may at least get us past the crash so I can
see where things might really be failing.

This change also backs out the change in r182282, since it didn't seem
to help anything.

[email protected]
BUG=386343

Review URL: https://codereview.chromium.org/591563002

git-svn-id: svn://svn.chromium.org/blink/trunk@182358 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 22, 2014
@caseq
Revert of Try #3 to fix the android layout tests crash in run-webkit-…
f5beb4b 
…tests. (patchset #2 id:20001 of https://codereview.chromium.org/591563002/)

Reason for revert:
Reverting, since this broke mac bots:

UnicodeEncodeError raised: 'ascii' codec can't encode characters in position 11332-11333: ordinal not in range(128)

Original issue's description:
> Try #3 to fix the android layout tests crash in run-webkit-tests.
> 
> This patch forcibly reencodes to ASCII at a different layer, matching
> where we're actually seeing the stack trace. This seems like an
> overly broad solution, but may at least get us past the crash so I can
> see where things might really be failing.
> 
> This change also backs out the change in r182282, since it didn't seem
> to help anything.
> 
> [email protected]
> BUG=386343
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182358

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=386343

Review URL: https://codereview.chromium.org/590983002

git-svn-id: svn://svn.chromium.org/blink/trunk@182387 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of Turn off autofill highlight when changing option in an auto…
2dfcbe8 
…filled <select> element (patchset #3 id:40001 of https://codereview.chromium.org/553983012/)

Reason for revert:
This makes the FormAutofillTest.ClearFormWithNodeContainingSelectOne browser_test fail.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=FormAutofillTest.ClearFormWithNodeContainingSelectOne&testType=browser_tests

Original issue's description:
> Turn off autofill highlight when changing option in an autofilled <select> element
> 
> [email protected], [email protected]
> BUG=412311
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182528

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=412311

Review URL: https://codereview.chromium.org/597853004

git-svn-id: svn://svn.chromium.org/blink/trunk@182569 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of Use the pinch viewport offset for tap disambiguation. (patc…
79bab42 
…hset #3 id:40001 of https://codereview.chromium.org/584893004/)

Reason for revert:
Makes webkit_unit_tests fail on Android:

[  FAILED  ] 1 test, listed below:
[  FAILED  ] WebFrameTest.DisambiguationPopupPinchViewport

 1 FAILED TEST
C   79.116s Main  ********************************************************************************
C   79.116s Main  Detailed Logs
C   79.116s Main  ********************************************************************************
C   79.119s Main  [FAIL] WebFrameTest.DisambiguationPopupPinchViewport:
C   79.119s Main  ../../third_party/WebKit/Source/web/tests/WebFrameTest.cpp:4413: Failure
C   79.119s Main  Value of: (frame->view()->scrollPosition()).y()
C   79.119s Main    Actual: 0
C   79.119s Main  Expected: (IntPoint(0, 400)).y()
C   79.119s Main  Which is: 400
C   79.119s Main  ../../third_party/WebKit/Source/web/tests/WebFrameTest.cpp:4434: Failure
C   79.119s Main  Value of: client.triggered()
C   79.119s Main    Actual: false
C   79.119s Main  Expected: true
C   79.120s Main  ********************************************************************************
C   79.120s Main  Summary
C   79.120s Main  ********************************************************************************
C   79.126s Main  [==========] 1467 tests ran.
C   79.126s Main  [  PASSED  ] 1466 tests.
C   79.126s Main  [  FAILED  ] 1 test, listed below:
C   79.126s Main  [  FAILED  ] WebFrameTest.DisambiguationPopupPinchViewport
C   79.126s Main  
C   79.126s Main  1 FAILED TEST
C   79.127s Main  ********************************************************************************

Original issue's description:
> Use the pinch viewport offset for tap disambiguation.
> 
> Account for the pinch vieport offset in the touch rectangle calculation
> and pass the offset to the client. The client needs the touch rectangle
> relative to both the main frame and to the screen.
> 
> This change is part 1 of 2 (part 2 is chromium side change https://codereview.chromium.org/595693002).
> 
> BUG=370470
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182534

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=370470

Review URL: https://codereview.chromium.org/602583003

git-svn-id: svn://svn.chromium.org/blink/trunk@182579 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of Initial draft - modify ViewportAnchor to know about both in…
2502bcc 
…ner and outer viewports. (patchset #11 id:200001 of https://codereview.chromium.org/556703005/)

Reason for revert:
The new test is failing on mac. Reverting for now so it can be investigated.

[  FAILED  ] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
[1471/1471] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
Retrying 2 tests (retry #3)
[ RUN      ] PinchViewportTest.TestResizeAfterVerticalScroll
../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
Value of: (pinchViewport.visibleRect().size()).width()
Actual: 45.94595
Expected: (FloatSize(50, 25)).width()
Which is: 50
../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
Value of: (pinchViewport.visibleRect().size()).height()
Actual: 22.972975
Expected: (FloatSize(50, 25)).height()
Which is: 25
../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:253: Failure
Value of: (frame()->view()->scrollPosition()).y()
Actual: 638
Expected: (IntPoint(0, 625)).y()
Which is: 625
../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:254: Failure
Value of: (pinchViewport.location()).y()
Actual: 62
Expected: (FloatPoint(0, 75)).y()
Which is: 75

Original issue's description:
> Fix pinch virtual viewport position after resize.
> 
> Associate the viewport anchor with the inner viewport.
> Adjust the inner and outer viewport positions after resize
> such that they both remain in their allowed range and the
> inner viewport origin scales proportionally within the
> outer viewport.
> 
> As a small cleanup, made the method ScrollView::scrollTo() protected.
> 
> BUG=364108
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182365

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=364108

Review URL: https://codereview.chromium.org/597113002

git-svn-id: svn://svn.chromium.org/blink/trunk@182580 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of Revert of Initial draft - modify ViewportAnchor to know abo…
aca131c 
…ut both inner and outer viewports. (patchset #1 id:1 of https://codereview.chromium.org/597113002/)

Reason for revert:
Reapplying, reverting this one shouldn't be necessary.

Original issue's description:
> Revert of Initial draft - modify ViewportAnchor to know about both inner and outer viewports. (patchset #11 id:200001 of https://codereview.chromium.org/556703005/)
> 
> Reason for revert:
> The new test is failing on mac. Reverting for now so it can be investigated.
> 
> [  FAILED  ] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> [1471/1471] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> Retrying 2 tests (retry #3)
> [ RUN      ] PinchViewportTest.TestResizeAfterVerticalScroll
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> Value of: (pinchViewport.visibleRect().size()).width()
> Actual: 45.94595
> Expected: (FloatSize(50, 25)).width()
> Which is: 50
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> Value of: (pinchViewport.visibleRect().size()).height()
> Actual: 22.972975
> Expected: (FloatSize(50, 25)).height()
> Which is: 25
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:253: Failure
> Value of: (frame()->view()->scrollPosition()).y()
> Actual: 638
> Expected: (IntPoint(0, 625)).y()
> Which is: 625
> ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:254: Failure
> Value of: (pinchViewport.location()).y()
> Actual: 62
> Expected: (FloatPoint(0, 75)).y()
> Which is: 75
> 
> Original issue's description:
> > Fix pinch virtual viewport position after resize.
> > 
> > Associate the viewport anchor with the inner viewport.
> > Adjust the inner and outer viewport positions after resize
> > such that they both remain in their allowed range and the
> > inner viewport origin scales proportionally within the
> > outer viewport.
> > 
> > As a small cleanup, made the method ScrollView::scrollTo() protected.
> > 
> > BUG=364108
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182365
> 
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=364108
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182580

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=364108

Review URL: https://codereview.chromium.org/597683007

git-svn-id: svn://svn.chromium.org/blink/trunk@182586 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss pushed a commit that referenced this issue Sep 24, 2014
@madsager
Revert of Revert of Revert of Initial draft - modify ViewportAnchor t…
562c11e 
…o know about both inner and outer viewports. (patchset #1 id:1 of https://codereview.chromium.org/597683007/)

Reason for revert:
Nope: I did have to revert this one. webkit_unit_test failures on mac are back.

Original issue's description:
> Revert of Revert of Initial draft - modify ViewportAnchor to know about both inner and outer viewports. (patchset #1 id:1 of https://codereview.chromium.org/597113002/)
> 
> Reason for revert:
> Reapplying, reverting this one shouldn't be necessary.
> 
> Original issue's description:
> > Revert of Initial draft - modify ViewportAnchor to know about both inner and outer viewports. (patchset #11 id:200001 of https://codereview.chromium.org/556703005/)
> > 
> > Reason for revert:
> > The new test is failing on mac. Reverting for now so it can be investigated.
> > 
> > [  FAILED  ] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> > [1471/1471] PinchViewportTest.TestResizeAfterHorizontalScroll (39 ms)
> > Retrying 2 tests (retry #3)
> > [ RUN      ] PinchViewportTest.TestResizeAfterVerticalScroll
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> > Value of: (pinchViewport.visibleRect().size()).width()
> > Actual: 45.94595
> > Expected: (FloatSize(50, 25)).width()
> > Which is: 50
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:251: Failure
> > Value of: (pinchViewport.visibleRect().size()).height()
> > Actual: 22.972975
> > Expected: (FloatSize(50, 25)).height()
> > Which is: 25
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:253: Failure
> > Value of: (frame()->view()->scrollPosition()).y()
> > Actual: 638
> > Expected: (IntPoint(0, 625)).y()
> > Which is: 625
> > ../../third_party/WebKit/Source/web/tests/PinchViewportTest.cpp:254: Failure
> > Value of: (pinchViewport.location()).y()
> > Actual: 62
> > Expected: (FloatPoint(0, 75)).y()
> > Which is: 75
> > 
> > Original issue's description:
> > > Fix pinch virtual viewport position after resize.
> > > 
> > > Associate the viewport anchor with the inner viewport.
> > > Adjust the inner and outer viewport positions after resize
> > > such that they both remain in their allowed range and the
> > > inner viewport origin scales proportionally within the
> > > outer viewport.
> > > 
> > > As a small cleanup, made the method ScrollView::scrollTo() protected.
> > > 
> > > BUG=364108
> > > 
> > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182365
> > 
> > [email protected],[email protected],[email protected],[email protected],[email protected]
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=364108
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182580
> 
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=364108
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182586

[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=364108

Review URL: https://codereview.chromium.org/601633003

git-svn-id: svn://svn.chromium.org/blink/trunk@182591 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoavweiss @nwtn