Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be great if one could send attachments such as images #133

Open
tobiasgrosser opened this issue Oct 22, 2024 · 2 comments
Open

Comments

@tobiasgrosser
Copy link

No description provided.

@timabbott
Copy link
Member

Hmm, yeah, that could be nice. Do you have a suggestion of how you'd want the interface to work for that?

@tobiasgrosser
Copy link
Author

tobiasgrosser commented Dec 12, 2024

@timabbott, i thought a bit about it. One option could be to allow markdown in the content field of github-actions-zulip, similar to how zulip itself references attachments. The URL could then be an absolute/relative filesystem URL. However, this might open some security holes, so you probably want this to be opt-in with a flag. Alternatively, the content string could allow placeholders for filenames "This is a message [File](fileA)", and an extra files field would then be used to map placeholders to local filenames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants