-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings window should also have "Night Mode" #1082
Comments
Structurally, the night theme setting is just for the Zulip webapp (aka for a particular organization), and can't be directly read/inherited by the app-level settings page (which are shared by all Zulip organizations). We also would need to do CSS for the app-level settings to support this, though it's a simple enough site that it's probably not hard. Do you spend much time in the app-level settings UI? I'm not sure how much work this would be to implement, but that'd at least give a sense as to the benefit. |
This is kind of a paper cut issue for me. It has a small effect on the user experience but tied in with a couple other issues it is fairly noticeable.
Considering all of that, I open the app-level settings more frequently than I want or need to. |
Thanks, that feedback is helpful! |
can I work on this issue ? |
Hello @r0nz-29! Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
Problem Description
When the "Night mode" is selected through the menu, the settings window is still a light theme.
Proposed Solution
The settings window should have a dark theme as well.
Describe alternatives you've considered
Sunglasses :)
Additional context
I am running Zulip 5.6.0 Desktop Appimage on Linux Mint 20.1
The text was updated successfully, but these errors were encountered: