Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: Support tapping a notification to open the conversation #123

Closed
chrisbobbe opened this issue May 26, 2023 · 1 comment · Fixed by #362
Closed

notifications: Support tapping a notification to open the conversation #123

chrisbobbe opened this issue May 26, 2023 · 1 comment · Fixed by #362
Assignees
@gnprice
Labels
a-notifications
Milestone
M0: Alpha

Comments

@chrisbobbe
Copy link
Collaborator

After #122.
@gnprice gnprice added this to the Alpha milestone May 27, 2023
@gnprice gnprice removed the m-alpha label May 27, 2023
@chrisbobbe
Copy link
Collaborator Author

It might be useful to study how we do this in zulip-mobile. With

, we simplify the case that was the most opaque in zulip-mobile, because it relied on a low-quality library: on iOS, tapping a notification to launch the app (from closed).

gnprice added a commit that referenced this issue Jun 14, 2023
@gnprice
doc: Convert remaining TODOs from readme into GitHub issues
04deea2 
Filed #187, #188, and #190.

Other items already existed as #80, #82, #95, #122, and #123,
or were already complete (a compose box, and three ways of
attaching something to a message.)
@gnprice gnprice self-assigned this Jul 14, 2023
@gnprice gnprice mentioned this issue Aug 15, 2023
Merged
@gnprice gnprice mentioned this issue Oct 27, 2023
Merged
gnprice added a commit that referenced this issue Oct 31, 2023
@gnprice
notif: Show notifications! on Android, in foreground
b6badf5 
This implements most of the remaining work of #320.

It doesn't yet deliver most of the user-facing value: for that, the
remaining piece will be to make notifications appear when the app is
in the background as well as when it's in the foreground.  I have a
draft for that and it works, but the tests require some more fiddling
which I may not get to today, so I wanted to get the bulk of this
posted for review.

Many other improvements still to be made are tracked as their own
issues: most notably iOS support #321, and opening a conversation
by tapping the notification #123.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 2, 2023
@gnprice
notif: Navigate to conversation on tapping notification
a4353a3 
Still only on Android; iOS support for notifications in general
is coming next.

Fixes: zulip#123
@gnprice gnprice mentioned this issue Nov 2, 2023
Merged
chrisbobbe pushed a commit to gnprice/zulip-flutter that referenced this issue Nov 6, 2023
@gnprice @chrisbobbe
notif: Navigate to conversation on tapping notification
dcf13e5 
Still only on Android; iOS support for notifications in general
is coming next.

This also only applies when the app is already running (either in
the foreground or the background) when the notification is opened.
The case where the app isn't already running and is launched from
the notification will be handled in an upcoming commit.

Fixes-partly: zulip#123
@chrisbobbe chrisbobbe mentioned this issue Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
a-notifications
Projects
Flutter app
Status: Done
Milestone
M0: Alpha
Development

Successfully merging a pull request may close this issue.

Navigate to conversation on tapping notification gnprice/zulip-flutter
2 participants
@gnprice @chrisbobbe