Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max_message_length instead of hardcoded limit of 10000 #1237

Open
chrisbobbe opened this issue Dec 30, 2024 · 5 comments
Open

Use max_message_length instead of hardcoded limit of 10000 #1237

chrisbobbe opened this issue Dec 30, 2024 · 5 comments
Labels
a-api Implementing specific parts of the Zulip server API a-compose Compose box, autocomplete, attaching files/images

Comments

@chrisbobbe
Copy link
Collaborator

We currently use a constant kMaxMessageLengthCodePoints. We should instead use max_message_length from the server; search for max_message_length at https://zulip.com/api/register-queue

Related issues

@chrisbobbe chrisbobbe added a-compose Compose box, autocomplete, attaching files/images a-api Implementing specific parts of the Zulip server API labels Dec 30, 2024
@gnprice gnprice added this to the M6: Post-launch milestone Dec 30, 2024
@Spyyy004
Copy link

Spyyy004 commented Jan 8, 2025

Hey, I am working on it. I have successfully fetched the max_message_length from the server and added it in the models. I am now working on integrating it with the compose_box widget.

@Spyyy004
Copy link

Spyyy004 commented Jan 8, 2025

Update : I did the integration with the sendbutton widget error checker function successfully but somehow i cant raise a PR now. Whenever i try to push the code to origin, it is giving me 403 error.

@apoorvapendse
Copy link
Contributor

Hey @Spyyy004, what is the url for the origin alias in your case?
Maybe it has something to do with that.

@Spyyy004
Copy link

Spyyy004 commented Jan 8, 2025

remote: Permission to zulip/zulip-flutter.git denied to Spyyy004.
fatal: unable to access 'https://github.com/zulip/zulip-flutter.git/': The requested URL returned error: 403

@apoorvapendse
Copy link
Contributor

can you run git remote get-url origin and paste the output.
I think that is where the issue is.
Also could you link the PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API a-compose Compose box, autocomplete, attaching files/images
Projects
Status: No status
Development

No branches or pull requests

4 participants