Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: Update message list on muting/unmuting a channel #1255

Open
chrisbobbe opened this issue Jan 4, 2025 · 1 comment
Open

msglist: Update message list on muting/unmuting a channel #1255

chrisbobbe opened this issue Jan 4, 2025 · 1 comment
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Jan 4, 2025

The message list should update when a channel is muted or unmuted. To reproduce:

  • Make sure #test here is unmuted
  • Send a message in #test here on CZO, in a topic that's not muted
  • Open "Combined feed" in the mobile app
  • See your message there
  • Mute the #test here channel (do this in the web app, pending UI for channel muting/unmuting #347)

Expected behavior: your message disappears
Actual behavior: the message does not disappear


A resumption of part of

which was closed as fixed by #822, even though that PR only handled topic mutes/unmutes. It looks like we haven't revisited the channel part of #421 since then, even though there's a TODO(#421) for this in the code.

An instance of #599:

It would be nice to have an automated check for TODO(#…)s that remain in the code when they're supposed to be deleted as part of fixing the specified issue. […] [T]hey might have been missed because there was actually something important to do that wasn't done.

Related issues

@chrisbobbe chrisbobbe added the a-msglist The message-list screen, except what's label:a-content label Jan 4, 2025
@chrisbobbe chrisbobbe added this to the M5: Launch milestone Jan 4, 2025
@chrisbobbe
Copy link
Collaborator Author

As part of fixing this issue, we should settle the three remaining TODO(#421)s in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Status: No status
Development

No branches or pull requests

1 participant