Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle system-group names in rendering @-mentions #1260

Open
gnprice opened this issue Jan 7, 2025 · 0 comments
Open

Handle system-group names in rendering @-mentions #1260

gnprice opened this issue Jan 7, 2025 · 0 comments
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-i18n Translation, localization, internationalization
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Jan 7, 2025

This is a follow-up to:

When rendering an @-mention of a group that is a system group, the group won't appear in our user-groups data. With #1259 we'll therefore still fall back to the name that's in the HTML, which will be a display-name for the group in English.

Instead, when rendering a system group, we should use an appropriate UI string which we include in our strings for translation. For the display-names the web app uses for system groups, see this message.

Related issues:

@gnprice gnprice added a-content Parsing and rendering Zulip HTML content, notably message contents a-i18n Translation, localization, internationalization labels Jan 7, 2025
@gnprice gnprice added this to the M7: Future milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-i18n Translation, localization, internationalization
Projects
Status: No status
Development

No branches or pull requests

1 participant