Say "DM" / "direct message" instead of "PM" / "private message", in code and UI

[gnprice]

This is a change that happened in the web UI a few weeks after I started prototyping the Flutter app:

• private-messages: Change user-facing strings to use "direct message". zulip#24224

It's also happening in the server API, though necessarily more gradually. See summary at:

• Use "direct" as the message type when sending direct/private messages. zulip-mobile#5725

The code still reflects the old name, in identifiers and comments. We should update it to the new name; this is easier to do the sooner we do it.

While we're at it, we should handle occurrences in UI text, too. I think the only one of these so far is in recipient headers.

Out of scope for this issue is to use the new name in the actual API, in the places where it's accepted. That's tracked as part of:

• Track Zulip feature level on ApiConnection; use it #146

---

To find places to update, use the following search:

$ git grep -P 'pm|Pm|PM|(?i:private)' -- lib test

That currently finds 43 lines, of which it looks like

• 4 are in the API;
• 4 are false positives;
• so 35 are in scope for this issue.

[PIG208]

zulip-flutter/lib/api/model/events.dart

Lines 718 to 724 in 1d24f6d

	/// As in [DeleteMessageEvent.messageType]
	/// or [UpdateMessageFlagsMessageDetail.type].
	@JsonEnum(fieldRename: FieldRename.snake)
	enum MessageType {
	stream,
	private;
	}

It appears that there are some additional instances of "private" for MessageType used in some event models. Should we reopen the issue?

[gnprice]

Hmm indeed, thanks. Rerunning the search command above, there's also InitialSnapshot.recentPrivateConversations.

It looks like both that and MessageType.private were introduced after this issue was closed by #152.

I'll open a new issue for it — I think it'll be easier to track the revived issue that way, since this old one was fixed a year ago.