Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer "Copy link to topic" #792

Open
gnprice opened this issue Jul 6, 2024 · 2 comments
Open

Offer "Copy link to topic" #792

gnprice opened this issue Jul 6, 2024 · 2 comments
Labels
help wanted server-9 Things new in Zulip Server 9.0

Comments

@gnprice
Copy link
Member

gnprice commented Jul 6, 2024

We should offer a "Copy link to topic" option.

This will be part of the topic action sheet. At the moment we don't have a topic action sheet; this can be the first item in it, or this issue can come after one of the other open issues for options to add to the topic action sheet:

In particular see #348 for a description of where the topic action sheet should appear.

When we do offer this option, the links it generates should be topic permalinks, when the server supports it (it's part of the upcoming Zulip Server 9.0) and once we're ready for Zulip clients in general to be generating topic permalinks. In other words, the zulip-flutter implementation of this feature should match this zulip-mobile issue:

and the eventual version (i.e. the version that gets merged, after any revisions) of the web side of this PR:

@gnprice gnprice added the server-9 Things new in Zulip Server 9.0 label Jul 6, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jul 6, 2024
@lakshya1goel
Copy link

Hi, I’m interested in working on the "Copy link to topic" feature for the topic action sheet. Before proceeding with the UI and integration, I wanted to confirm whether Zulip Server 9.0, which supports topic permalinks, is already available or if there’s a specific timeline for its release.

Since the feature involves generating topic links as permalinks, I’d like to ensure the server is ready to handle this before implementing it on the Flutter side.

Looking forward to any updates!
Thanks!

@gnprice
Copy link
Member Author

gnprice commented Dec 27, 2024

Yes, if you do a web search for "zulip server 9.0", you'll find the announcement:
https://blog.zulip.com/2024/07/25/zulip-9-0-released/

In any case a PR for this issue will need to support generating both permalinks and the older non-permalinks. As I said above, we'll want to generate permalinks only when the server supports it; and not all servers have upgraded to 9.0. See our README at https://github.com/zulip/zulip-flutter#server-compatibility, and see the existing code for examples of how we handle differences between server versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted server-9 Things new in Zulip Server 9.0
Projects
Status: No status
Development

No branches or pull requests

2 participants