Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support (un)resolving topics #1075

Open
neiljp opened this issue Jul 10, 2021 · 0 comments · May be fixed by #1544
Open

Support (un)resolving topics #1075

neiljp opened this issue Jul 10, 2021 · 0 comments · May be fixed by #1544
Labels
area: UI General user interface update GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client version parity: 5
Milestone
Next Release

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jul 10, 2021

This feature is likely to be in Zulip 5.0 and while still under development appears fairly settled and ready to be implemented.

This feature involves toggling a prefix+space marker, though we should check the web app to confirm what is required.

We don't yet have one, but this is likely most easily presented through an option in a TopicsPopUp.
@neiljp neiljp added area: UI General user interface update missing feature: user A missing feature for all users, present in another Zulip client labels Jul 10, 2021
@neiljp neiljp added GSoC Possible GSoC project component high priority should be done as soon as possible labels Mar 8, 2022
@neiljp neiljp added this to the Release after next milestone Mar 13, 2022
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Jun 20, 2022
@srdeotarse
model: Handle (un)resolving topics.
5ee4075 
Fixes zulip#1075
Still trying to figure out way of updating topic name with
RESOLVED_TOPIC_PREFIX.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Jun 20, 2022
@srdeotarse
model: Handle (un)resolving topics.
d11e8d0 
Fixes zulip#1075
Still trying to figure out way of updating topic name with
RESOLVED_TOPIC_PREFIX.
@srdeotarse srdeotarse mentioned this issue Jun 20, 2022
Open
4 tasks
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Jun 29, 2022
@srdeotarse
model: Handle (un)resolving topics.
d9534da 
Fixes zulip#1075
First using get_messages api method to get most recent
message sent by user in the topic for which TopicInfoView
is toggled.
Then using fetch message to edit the topic and propagate
mode as change_all to (un)resolve topics.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Jul 17, 2022
@srdeotarse
model: Handle (un)resolving topics.
003d857 
Fixes zulip#1075
First using get_messages api method to get most recent
message sent by user in the topic for which TopicInfoView
is toggled.
Then using fetch message to edit the topic and propagate
mode as change_all to (un)resolve topics.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Jul 17, 2022
@srdeotarse
model: Handle (un)resolving topics.
8509e66 
Fixes zulip#1075
First using get_messages api method to get most recent
message sent by user in the topic for which TopicInfoView
is toggled.
Then using fetch message to edit the topic and propagate
mode as change_all to (un)resolve topics.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Aug 5, 2022
@srdeotarse
model: Handle (un)resolving topics.
0fdf941 
Fixes zulip#1075
First using get_messages api method to get most recent
message sent by user in the topic for which TopicInfoView
is toggled.
Then using fetch message to edit the topic and propagate
mode as change_all to (un)resolve topics.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Aug 22, 2022
@srdeotarse
model: Handle (un)resolving topics.
9d9068e 
Fixes zulip#1075
Add new get_latest_message_in_topic function to get most recent message
sent by user in the topic for which TopicInfoView is toggled.
Then check realm_community_topic_editing_limit_seconds before using
update_stream_message to edit the topic with propagate mode as
change_all to (un)resolve topics.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Sep 2, 2022
@srdeotarse
model: Add toggle_topic_resolved_status function to (un)resolve topics.
493e3c4 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Sep 4, 2022
@srdeotarse
model: Add toggle_topic_resolved_status function to (un)resolve topics.
81ce518 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Sep 6, 2022
@srdeotarse
model: Add un_resolve_topic function to (un)resolve topics.
fcf1c56 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Sep 10, 2022
@srdeotarse
model: Add un_resolve_topic function to (un)resolve topics.
24d27e1 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
neiljp pushed a commit to srdeotarse/zulip-terminal that referenced this issue Sep 10, 2022
@srdeotarse @neiljp
model: Add un_resolve_topic function to (un)resolve topics.
17be9ed 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Oct 13, 2022
@srdeotarse
model: Add toggle_topic_resolve_status function to (un)resolve topics.
abc3836 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 7, 2023
@srdeotarse
model: Add toggle_topic_resolve_status function to (un)resolve topics.
cc9f6cb 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 8, 2023
@srdeotarse
model: Add toggle_topic_resolve_status function to (un)resolve topics.
8213368 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
srdeotarse added a commit to srdeotarse/zulip-terminal that referenced this issue Apr 8, 2023
@srdeotarse
model: Add toggle_topic_resolve_status function to (un)resolve topics.
0433e30 
Fixes zulip#1075
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.
@rsashank rsashank linked a pull request Sep 5, 2024 that will close this issue
Open
18 tasks
rsashank added a commit to rsashank/zulip-terminal that referenced this issue Sep 5, 2024
@rsashank @srdeotarse
model: Add toggle_topic_resolve_status function to (un)resolve topics.
b64fccc 
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.

Fixes zulip#1075.

Co-authored-by: Shivam Deotarse <[email protected]>
rsashank added a commit to rsashank/zulip-terminal that referenced this issue Sep 5, 2024
@rsashank @srdeotarse
model: Add toggle_topic_resolve_status function to (un)resolve topics.
20f33d2 
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.

Fixes zulip#1075.

Co-authored-by: Shivam Deotarse <[email protected]>
rsashank added a commit to rsashank/zulip-terminal that referenced this issue Sep 5, 2024
@rsashank @srdeotarse
model: Add toggle_topic_resolve_status function to (un)resolve topics.
82e3b87 
The function calls get_latest_message_in_topic to fetch recent message
in topic to be (un)resolved. It verifies user and editing conditions
using can_user_edit_topic function and finally add or remove
RESOLVED_TOPIC_PREFIX from topic name.

Fixes zulip#1075.

Co-authored-by: Shivam Deotarse <[email protected]>
rsashank added a commit to rsashank/zulip-terminal that referenced this issue Sep 5, 2024
@rsashank @srdeotarse
buttons: Add TOPIC_INFO shortcut to TopicButton.
a570d28 
Fixes zulip#1075.

Co-authored-by: Shivam Deotarse <[email protected]>
rsashank pushed a commit to rsashank/zulip-terminal that referenced this issue Sep 30, 2024
@srdeotarse @rsashank
buttons: Add TOPIC_INFO shortcut to TopicButton.
955fb11 
Fixes zulip#1075.
rsashank pushed a commit to rsashank/zulip-terminal that referenced this issue Sep 30, 2024
@srdeotarse @rsashank
buttons: Add TOPIC_INFO shortcut to TopicButton.
76fafdf 
Fixes zulip#1075.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: UI General user interface update GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client version parity: 5
Projects
None yet
Milestone
Next Release
Development

Successfully merging a pull request may close this issue.

Support (un)resolving topics rsashank/zulip-terminal
1 participant
@neiljp