Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing features for editing sent messages. #223

Closed
1 of 2 tasks
amanagr opened this issue Dec 28, 2018 · 2 comments
Closed
1 of 2 tasks

Implement missing features for editing sent messages. #223

amanagr opened this issue Dec 28, 2018 · 2 comments
Labels
help wanted This issue should be clear enough to work on

Comments

@amanagr
Copy link
Member

amanagr commented Dec 28, 2018 •
edited by neiljp
Loading

TODO:

  • propagate_mode: Add support for "change_later" & "change_all". Only "change_one" is supported now. This will also involve changing all the messages' topic after the edited message if a topic change is requested.
  • Disable stream_edit_box and to_edit_box when editing message since they cannot be edited once a message is sent. Making them not editable will reduce confusion too. The best way to do it would be to add disable feature to ReadlineEdit.
@amanagr amanagr added enhancement New feature or request help wanted This issue should be clear enough to work on next major release labels Dec 28, 2018
@amanagr amanagr self-assigned this Mar 5, 2019
@zulip zulip deleted a comment from zulipbot Jun 24, 2019
@amanagr amanagr changed the title Add feature to edit sent messages. Implement missing features for editing sent messages. Jun 24, 2019
@amanagr amanagr removed next major release enhancement New feature or request labels Jun 24, 2019
@amanagr amanagr self-assigned this Jun 24, 2019
@zulipbot
Copy link
Member

zulipbot commented Jul 4, 2019 •
edited
Loading

Hello @amanagr, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@neiljp
Copy link
Collaborator

neiljp commented Jan 28, 2021

I'm closing this since there are many more issues registered for area: message editing now. The first in the list is now complete, and the second is in #774.

@neiljp neiljp closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted This issue should be clear enough to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neiljp @amanagr @zulipbot