Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection of stream with no previous conversation does not update 'current' stream in top bar. #259

Closed
sumanthvrao opened this issue Jan 14, 2019 · 17 comments · May be fixed by #278
Closed

Selection of stream with no previous conversation does not update 'current' stream in top bar. #259

sumanthvrao opened this issue Jan 14, 2019 · 17 comments · May be fixed by #278
Labels
bug Something isn't working help wanted This issue should be clear enough to work on

Comments

@sumanthvrao
Copy link
Member

When the stream is changed by to one with no previous messages, the 'current' stream marker ( colorful one) does not change and remains the old stream name itself.

To reproduce:

  1. login in as [email protected] ( an example)
  2. click on stream Denmark (contains previous conversation)
  3. now click on stream support (Does not contain previous conversations)

Notice how the current stream marker in top bar remains to be Denmark.
@sumanthvrao sumanthvrao changed the title Selection of stream with no previous conversation does not update 'current' stream in search bar Selection of stream with no previous conversation does not update 'current' stream in top bar. Jan 14, 2019
@neiljp
Copy link
Collaborator

neiljp commented Jan 14, 2019

This is likely very similar to #138, though that is for muted streams.

That said, I am manually testing #252 for a muted stream rather than an empty stream - the current effect is essentially the same, since we don't show content for muted streams right now.

@neiljp neiljp added the bug Something isn't working label Jan 16, 2019
@neiljp neiljp mentioned this issue Jan 18, 2019
Open
@sumanthvrao
Copy link
Member Author

@zulipbot claim

@zulipbot
Copy link
Member

Hello @sumanthvrao!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

1 similar comment
@zulipbot
Copy link
Member

Hello @sumanthvrao!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@sumanthvrao
Copy link
Member Author

@zulipbot add "help wanted"

@zulipbot zulipbot added the help wanted This issue should be clear enough to work on label Jan 21, 2019
@sumanthvrao
Copy link
Member Author

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @sumanthvrao! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 26, 2019
@sumanthvrao
Sets current stream marker for empty streams.
2552dc5 
Current stream headers for empty/muted/new streams
used to not get updated. We now introduce a dummy
message to update label.

Fixes: zulip#259
@sumanthvrao sumanthvrao mentioned this issue Jan 26, 2019
Open
2 tasks
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 26, 2019
@sumanthvrao
Sets current stream marker for empty streams.
67c0123 
Current stream headers for empty/muted/new streams
used to not get updated. We now introduce a dummy
message to update label.

Fixes: zulip#259
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 27, 2019
@sumanthvrao
Sets current stream marker for empty streams.
3574948 
Current stream headers for empty streams
used to not get updated. A dummy message
is used to update label.

Fixes: zulip#259
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 28, 2019
@sumanthvrao
Sets current narrow label for empty narrow.
333ddf0 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
Sets current narrow label for empty narrow.
87835fb 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
Updated bug fixes for issues zulip#247, zulip#259, zulip#266.
bc9acd2
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
Sets current narrow label for empty narrow.
a19134e 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
Sets current narrow label for empty narrow.
a9a7398 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
629bab6
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Jan 31, 2019
@sumanthvrao
Sets current narrow label for empty narrow.
fc9ca2f 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 1, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
94e9100
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 1, 2019
@sumanthvrao
Sets current narrow label for empty narrow.
9d6a6c9 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 1, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
a601d9c
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 1, 2019
@sumanthvrao
boxes/utils/view: Sets current narrow label for empty narrow.
2b0b628 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 3, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
5a3a105
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 3, 2019
@sumanthvrao
boxes/utils/view: Sets current narrow label for empty narrow.
60ef820 
A dummy message is used to update label for
empty narrow headers which did not change before.
Both streams and PM covered

Fixes: zulip#259
Fixes: zulip#266
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 18, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
77ee3de
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 19, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
7645da8
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 19, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
79a6cbe
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 19, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
97c37d2
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 20, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
f2ae496
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 21, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
3593203
@zulipbot
Copy link
Member

zulipbot commented Feb 23, 2019 •
edited
Loading

Hello @sumanthvrao, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Feb 27, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
11b6ee3
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 3, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
7bc7701
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 3, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
7d85f07
@sumanthvrao
Copy link
Member Author

@zulipbot claim

sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Mar 5, 2019
@sumanthvrao
changelog: Added fixes for issues zulip#247, zulip#259, zulip#266.
d81ac28
@zulipbot
Copy link
Member

zulipbot commented May 2, 2019 •
edited
Loading

Hello @sumanthvrao, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@sumanthvrao
Copy link
Member Author

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jun 14, 2019 •
edited
Loading

Hello @sumanthvrao, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@sumanthvrao
Copy link
Member Author

@zulipbot still working on it.

@preetmishra preetmishra mentioned this issue Apr 20, 2020
Closed
@neiljp neiljp mentioned this issue May 29, 2024
Open
@neiljp
Copy link
Collaborator

neiljp commented May 29, 2024

Closing in favor of #1506, which is the general case.

@neiljp neiljp closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted This issue should be clear enough to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sets current narrow marker for empty narrows. sumanthvrao/zulip-terminal
3 participants
@neiljp @zulipbot @sumanthvrao