Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Support stream pinning state changes #411

Closed
neiljp opened this issue Jun 28, 2019 · 3 comments
Closed

Events: Support stream pinning state changes #411

neiljp opened this issue Jun 28, 2019 · 3 comments
Labels
area: event handling How events from the server are responded to enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org

Comments

@neiljp
Copy link
Collaborator

neiljp commented Jun 28, 2019

Currently the pinned state updated in a different frontend only changes if we restart ZT. While this works for now - ZT is pretty quick to restart, and the stream is just in a different location in the interface - it would be useful to develop this. This would also allow addition of pinning/unpinning UI at a later stage.

This should be rather straightforward to add, though potentially needs consideration in the context of #410.

@neiljp neiljp added enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org labels Jun 28, 2019
@kaustubh-nair
Copy link
Member

@neiljp fixed in #695 ?

@neiljp
Copy link
Collaborator Author

neiljp commented Jul 31, 2020

@kaustubh-nair Could we maintain focus within the stream on pinning state change first? I erroneously referred to this as related to #617 in #695, whereas this is stream-list related, not topic-list related. This is the #410-related aspect, where the focus changes unexpectedly just as the user is about to do something with the focused element.

@neiljp
Copy link
Collaborator Author

neiljp commented Apr 23, 2024

Catching up on this, this was effectively completed by #695, which also integrated existing stream muting events and updating into a UI in the stream popup, where they could be modified from ZT.

When #695 was merged, I left this open since there were related apparent issues.

One aspect of that was expanded into #747, to ensure that the stream popup data was synchronized with server data, if the latter changed while the popup was open.

The other is now expanded into #1487 so I'm closing this.

@neiljp neiljp closed this as completed Apr 23, 2024
@neiljp neiljp added the area: event handling How events from the server are responded to label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: event handling How events from the server are responded to enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org
Projects
None yet
Development

No branches or pull requests

2 participants