Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on narrows with inactive bots/deactivated users #956

Open
Ezio-Sarthak opened this issue Mar 23, 2021 · 1 comment
Open

Crash on narrows with inactive bots/deactivated users #956

Ezio-Sarthak opened this issue Mar 23, 2021 · 1 comment
Labels
bug: crash high priority should be done as soon as possible

Comments

@Ezio-Sarthak
Copy link
Member

Ezio-Sarthak commented Mar 23, 2021

Steps to reproduce:

  • Make a bot (potentially of any type)
  • Start the conversation (a couple of messages, to help narrow to it later)
  • Deactivate the bot (from web app :))
  • Perform either narrowing or quote reply actions on that conversation in ZT

You'll encounter a traceback, with the error Key error: <bot-email>. The key error corresponds to Model.user_dict.

We currently don't support tracking users which are deactivated (including inactive bots). We do check that a narrow exists first in other cases (e.g., narrowing to stream). This might be an option for users too. We can also add a check based on the server response.

@neiljp neiljp added the high priority should be done as soon as possible label Mar 14, 2022
@neiljp
Copy link
Collaborator

neiljp commented Mar 14, 2022

This is likely blocked on handling events as users add and leave the organization, part of #993.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: crash high priority should be done as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants