Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #26 #33

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

khushi-hura
Copy link

I have tried to manage recording audios and sending them to peers.
There are three icon buttons working on this:

  1. Mic: On pressing mic, the sender is able to record audio.
  2. Pause: On pressing this button, the audio stops to record.
  3. Send: On pressing this button, the sender is able to send the audio to their peer chat as a media.
audioDemo.mp4

Looking forward to working on this issue more deeply after getting reviewed!

@bhavik-mangla
Copy link
Contributor

bhavik-mangla commented Dec 27, 2024

Hi @khushi-hura ,

Good efforts on the feature implementation! However, this is a big task, and it will require more time to polish. Here are a few points that need improvement:

  1. Duplicate Send Buttons: There seem to be two send buttons in the UI. Please clarify their purpose or remove the redundancy.
  2. Peer Messaging: The feature for sending messages to another connected peer is unclear. It currently appears as if only one device is involved. Please address this.
  3. Audio Recording UI: Incorporate a long-press feature and animations for recording audio, similar to WhatsApp's UI for better user experience.
  4. Add functionality to save audio files - Ensure that the audio file is saved in the receiver's device in the correct format.
  5. Audio Playback: A user should be able to listen to the audio message by clicking on it.
  6. UI Distinction: Differentiate between the UI for audio messages and file messages to make them visually distinct.

Also you are not following the contribution guidelines as this PR is merging the commit to main branch

@khushi-hura
Copy link
Author

hey @bhavik-mangla gsoc-2025 is the branch in my fork repository, in which branches should I request for the commits to be merged in upstream repository while raising PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants