Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1344 (terminal cant find @issue#1344 for cloning and local testing) #1

Merged
merged 12 commits into from
Oct 28, 2024

Conversation

Ajnus
Copy link
Owner

@Ajnus Ajnus commented Oct 28, 2024

What does this PR do, and why?

Replaces instances of:
private, privates, _ private, private _, PRIVATE, PRIVATES, Private , pm, pms, _ pm, pm _, PM, Pm
(and derivatives, e.g: _is_private_message_to_self, private_msg_ids, private_msg_ids_by_user_ids, (...))

to Direct Message terminology, avoiding the test_model.py, model.py files, strings and other instances related to the API, for API consistency reasons, while "exploring other parts", such as replacing comments.

This PR consists of the - on-chat debated - first part of altering just internal code, not the second that focus on API related code.

External discussion & connections

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

Ajnus added 12 commits October 23, 2024 07:36
…onsistency reasons, and "exploring other parts")
… consistency reasons, and "exploring other parts")
… consistency reasons, and "exploring other parts")
…" & "replace 'private_' with 'direct_'": _is_private_message_to_self-> _is_direct_message_to_self; private_msg_ids-> direct_msg_ids; private_msg_ids_by_user_ids->direct_msg_ids_by_user_ids (altough strings, altough also in model and test_model, necessary changes for references to previously altered internal variables)
…model.py, for API consistency reasons, and "exploring other parts")
…consistency reasons, and "exploring other parts")
…consistency reasons, and "exploring other parts")
…or API consistency reasons, and "exploring other parts")
@Ajnus Ajnus merged commit a780310 into main Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant