Issue #1344 (terminal cant find @issue#1344 for cloning and local testing) #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
Replaces instances of:
private, privates, _ private, private _, PRIVATE, PRIVATES, Private , pm, pms, _ pm, pm _, PM, Pm
(and derivatives, e.g: _is_private_message_to_self, private_msg_ids, private_msg_ids_by_user_ids, (...))
to Direct Message terminology, avoiding the
test_model.py
,model.py
files, strings and other instances related to the API, for API consistency reasons, while "exploring other parts", such as replacing comments.This PR consists of the - on-chat debated - first part of altering just internal code, not the second that focus on API related code.
External discussion & connections
#T1344 Migrate internal code to use Direct Message terminology
How did you test this?
Self-review checklist for each commit