-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create StudioTable components #12731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
label
May 8, 2024
...s/studio-components/src/components/StudioTableLocalPagination/StudioTableLocalPagination.tsx
Fixed
Show fixed
Hide fixed
ErlingHauan
force-pushed
the
studio-table-components
branch
from
May 13, 2024 10:08
dc83829
to
62ac455
Compare
…tudio-table-components
ErlingHauan
force-pushed
the
studio-table-components
branch
from
May 13, 2024 13:16
62ac455
to
a2f3929
Compare
framitdavid
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErlingHauan, solid work! 👏
...dio-components/src/components/StudioTableLocalPagination/StudioTableLocalPagination.test.tsx
Show resolved
Hide resolved
...s/studio-components/src/components/StudioTableLocalPagination/StudioTableLocalPagination.tsx
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioTableRemotePagination/utils.test.tsx
Outdated
Show resolved
Hide resolved
framitdavid
approved these changes
May 15, 2024
ErlingHauan
force-pushed
the
studio-table-components
branch
from
May 15, 2024 18:04
6657af5
to
dd8a207
Compare
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dashboard
Area: Related to the dashboard application
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created two new Studio components,
StudioTableRemotePagination
andStudioTableLocalPagination
. They are visually identical, but handles pagination and sorting differently.StudioTableRemotePagination
should be used where pagination and sorting is handled externally, and data is fetched pagewise in chunks. This will be the replacement of the MUI DataGrid component that is currently used in the dashboard.StudioTableLocalPagination
is a wrapper aroundStudioTableRemotePagination
. It should be used when a complete data set has been fetched. Here, the pagination and sorting will be handled internally by the component itself.Screenshot
Related Issue(s)
#9191
Verification
Documentation